firmware: Remove redundant log messages from drivers
authorBen Hutchings <ben@decadent.org.uk>
Sun, 9 Dec 2012 16:40:31 +0000 (16:40 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 4 Jan 2017 19:39:36 +0000 (19:39 +0000)
Now that firmware_class logs every success and failure consistently,
many other log messages can be removed from drivers.

This will probably need to be split up into multiple patches prior to
upstream submission.

Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name firmware-remove-redundant-log-messages-from-drivers.patch

157 files changed:
arch/arm/mach-netx/xc.c
arch/cris/arch-v32/drivers/iop_fw_load.c
arch/x86/kernel/cpu/microcode/amd.c
drivers/atm/ambassador.c
drivers/atm/fore200e.c
drivers/bluetooth/ath3k.c
drivers/bluetooth/bcm203x.c
drivers/bluetooth/bfusb.c
drivers/bluetooth/bt3c_cs.c
drivers/bluetooth/btmrvl_sdio.c
drivers/char/dsp56k.c
drivers/dma/imx-sdma.c
drivers/gpu/drm/mga/mga_warp.c
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
drivers/gpu/drm/r128/r128_cce.c
drivers/gpu/drm/radeon/ni.c
drivers/gpu/drm/radeon/r100.c
drivers/gpu/drm/radeon/r600.c
drivers/infiniband/hw/qib/qib_sd7220.c
drivers/input/touchscreen/atmel_mxt_ts.c
drivers/isdn/hardware/mISDN/speedfax.c
drivers/media/common/siano/smscoreapi.c
drivers/media/dvb-frontends/af9013.c
drivers/media/dvb-frontends/bcm3510.c
drivers/media/dvb-frontends/cx24116.c
drivers/media/dvb-frontends/drxd_hard.c
drivers/media/dvb-frontends/drxk_hard.c
drivers/media/dvb-frontends/ds3000.c
drivers/media/dvb-frontends/nxt200x.c
drivers/media/dvb-frontends/or51132.c
drivers/media/dvb-frontends/or51211.c
drivers/media/dvb-frontends/sp8870.c
drivers/media/dvb-frontends/sp887x.c
drivers/media/dvb-frontends/tda10048.c
drivers/media/dvb-frontends/tda1004x.c
drivers/media/dvb-frontends/tda10071.c
drivers/media/i2c/cx25840/cx25840-firmware.c
drivers/media/pci/bt8xx/bttv-cards.c
drivers/media/pci/cx18/cx18-av-firmware.c
drivers/media/pci/cx18/cx18-dvb.c
drivers/media/pci/cx18/cx18-firmware.c
drivers/media/pci/cx23885/cx23885-417.c
drivers/media/pci/cx23885/cx23885-cards.c
drivers/media/pci/cx88/cx88-blackbird.c
drivers/media/pci/ivtv/ivtv-firmware.c
drivers/media/pci/ngene/ngene-core.c
drivers/media/pci/saa7164/saa7164-fw.c
drivers/media/pci/ttpci/av7110.c
drivers/media/pci/ttpci/av7110_hw.c
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
drivers/media/radio/radio-wl1273.c
drivers/media/radio/wl128x/fmdrv_common.c
drivers/media/tuners/tuner-xc2028.c
drivers/media/usb/cpia2/cpia2_core.c
drivers/media/usb/cx231xx/cx231xx-417.c
drivers/media/usb/dvb-usb/dib0700_devices.c
drivers/media/usb/dvb-usb/dvb-usb-firmware.c
drivers/media/usb/dvb-usb/gp8psk.c
drivers/media/usb/dvb-usb/opera1.c
drivers/media/usb/go7007/go7007-driver.c
drivers/media/usb/go7007/go7007-fw.c
drivers/media/usb/go7007/go7007-loader.c
drivers/media/usb/gspca/vicam.c
drivers/media/usb/pvrusb2/pvrusb2-hdw.c
drivers/media/usb/s2255/s2255drv.c
drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c
drivers/media/usb/ttusb-dec/ttusb_dec.c
drivers/misc/ti-st/st_kim.c
drivers/net/can/softing/softing_fw.c
drivers/net/ethernet/3com/typhoon.c
drivers/net/ethernet/adaptec/starfire.c
drivers/net/ethernet/alteon/acenic.c
drivers/net/ethernet/broadcom/bnx2.c
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
drivers/net/ethernet/broadcom/tg3.c
drivers/net/ethernet/brocade/bna/cna_fwimg.c
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
drivers/net/ethernet/intel/e100.c
drivers/net/ethernet/myricom/myri10ge/myri10ge.c
drivers/net/ethernet/smsc/smc91c92_cs.c
drivers/net/ethernet/sun/cassini.c
drivers/net/hamradio/yam.c
drivers/net/usb/kaweth.c
drivers/net/wimax/i2400m/fw.c
drivers/net/wireless/ath/ath9k/hif_usb.c
drivers/net/wireless/ath/carl9170/usb.c
drivers/net/wireless/atmel/at76c50x-usb.c
drivers/net/wireless/atmel/atmel.c
drivers/net/wireless/broadcom/b43/main.c
drivers/net/wireless/broadcom/b43legacy/main.c
drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
drivers/net/wireless/intel/ipw2x00/ipw2100.c
drivers/net/wireless/intel/ipw2x00/ipw2200.c
drivers/net/wireless/intel/iwlegacy/3945-mac.c
drivers/net/wireless/intel/iwlwifi/iwl-drv.c
drivers/net/wireless/intersil/orinoco/fw.c
drivers/net/wireless/intersil/orinoco/orinoco_usb.c
drivers/net/wireless/intersil/p54/p54pci.c
drivers/net/wireless/intersil/p54/p54spi.c
drivers/net/wireless/intersil/p54/p54usb.c
drivers/net/wireless/intersil/prism54/islpci_dev.c
drivers/net/wireless/marvell/libertas_tf/if_usb.c
drivers/net/wireless/marvell/mwifiex/main.c
drivers/net/wireless/marvell/mwl8k.c
drivers/net/wireless/ralink/rt2x00/rt2x00firmware.c
drivers/net/wireless/realtek/rtlwifi/core.c
drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c
drivers/net/wireless/ti/wl1251/main.c
drivers/net/wireless/ti/wlcore/main.c
drivers/net/wireless/zydas/zd1201.c
drivers/net/wireless/zydas/zd1211rw/zd_usb.c
drivers/scsi/advansys.c
drivers/scsi/aic94xx/aic94xx_init.c
drivers/scsi/aic94xx/aic94xx_seq.c
drivers/scsi/bfa/bfad.c
drivers/scsi/ipr.c
drivers/scsi/pm8001/pm8001_ctl.c
drivers/scsi/qla1280.c
drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_nx.c
drivers/scsi/qla2xxx/qla_os.c
drivers/scsi/qlogicpti.c
drivers/staging/media/lirc/lirc_zilog.c
drivers/staging/rtl8192u/r819xU_firmware.c
drivers/staging/rtl8712/hal_init.c
drivers/staging/slicoss/slicoss.c
drivers/staging/vt6656/firmware.c
drivers/tty/cyclades.c
drivers/tty/moxa.c
drivers/tty/serial/icom.c
drivers/tty/serial/ucc_uart.c
drivers/usb/atm/cxacru.c
drivers/usb/atm/ueagle-atm.c
drivers/usb/misc/emi26.c
drivers/usb/misc/ezusb.c
drivers/usb/misc/isight_firmware.c
drivers/usb/serial/io_edgeport.c
drivers/usb/serial/io_ti.c
drivers/usb/serial/ti_usb_3410_5052.c
drivers/video/fbdev/broadsheetfb.c
drivers/video/fbdev/metronomefb.c
sound/drivers/vx/vx_hwdep.c
sound/isa/msnd/msnd_pinnacle.c
sound/isa/sscape.c
sound/isa/wavefront/wavefront_synth.c
sound/pci/asihpi/hpidspcd.c
sound/pci/cs46xx/cs46xx_lib.c
sound/pci/echoaudio/echoaudio.c
sound/pci/emu10k1/emu10k1_main.c
sound/pci/hda/hda_intel.c
sound/pci/korg1212/korg1212.c
sound/pci/mixart/mixart_hwdep.c
sound/pci/pcxhr/pcxhr_hwdep.c
sound/pci/riptide/riptide.c
sound/pci/rme9652/hdsp.c
sound/soc/codecs/wm2000.c
sound/usb/6fire/firmware.c

index f1c972d87bacc164b297b6e7f8088818a09aa168..496778446b14e2295ed2e2df33c9759ae5e7245c 100644 (file)
@@ -127,10 +127,8 @@ int xc_request_firmware(struct xc *x)
 
        ret = request_firmware(&fw, name, x->dev);
 
-       if (ret < 0) {
-               dev_err(x->dev, "request_firmware failed\n");
+       if (ret)
                return ret;
-       }
 
        head = (struct fw_header *)fw->data;
        if (head->magic != 0x4e657458) {
index 2f8ea0f7a63c30e77f7948b404bc74618cc6e421..4b8e651935fe3ed49b00b8ce5c6dcd605a4d7270 100644 (file)
@@ -74,12 +74,7 @@ int iop_fw_load_spu(const unsigned char *fw_name, unsigned int spu_inst)
                                  fw_name,
                                  &iop_spu_device[spu_inst]);
        if (retval != 0)
-       {
-               printk(KERN_ERR
-                      "iop_load_spu: Failed to load firmware \"%s\"\n",
-                      fw_name);
                return retval;
-       }
        data = (u32 *) fw_entry->data;
 
        /* acquire ownership of memory controller */
@@ -137,12 +132,7 @@ int iop_fw_load_mpu(unsigned char *fw_name)
        /* get firmware */
        retval = request_firmware(&fw_entry, fw_name, &iop_mpu_device);
        if (retval != 0)
-       {
-               printk(KERN_ERR
-                      "iop_load_spu: Failed to load firmware \"%s\"\n",
-                      fw_name);
                return retval;
-       }
        data = (u32 *) fw_entry->data;
 
        /* disable MPU */
index 017bda12caaed9c46f60fccc90f05d861e58e1ba..570268981659b923c06101afe94b664b69f50486 100644 (file)
@@ -917,10 +917,8 @@ static enum ucode_state request_microcode_amd(int cpu, struct device *device,
        if (c->x86 >= 0x15)
                snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86);
 
-       if (request_firmware_direct(&fw, (const char *)fw_name, device)) {
-               pr_debug("failed to load file %s\n", fw_name);
+       if (request_firmware_direct(&fw, (const char *)fw_name, device))
                goto out;
-       }
 
        ret = UCODE_ERROR;
        if (*(u32 *)fw->data != UCODE_MAGIC) {
index f1a9198dfe5a4966cbe7f433b357005501eb002a..90f2568f63c5e8dce815e68dd2e9334527023e96 100644 (file)
@@ -1929,10 +1929,8 @@ static int ucode_init(loader_block *lb, amb_dev *dev)
   int res;
 
   res = request_ihex_firmware(&fw, "atmsar11.fw", &dev->pci_dev->dev);
-  if (res) {
-    PRINTK (KERN_ERR, "Cannot load microcode data");
+  if (res)
     return res;
-  }
 
   /* First record contains just the start address */
   rec = (const struct ihex_binrec *)fw->data;
index 75dde903b2383af33387025d7f93ac5fa0d902b4..573bbb7b00169e2e32937fd8427a89b905fabf18 100644 (file)
@@ -2506,10 +2506,9 @@ static int fore200e_load_and_start_fw(struct fore200e *fore200e)
        return err;
 
     sprintf(buf, "%s%s", fore200e->bus->proc_name, FW_EXT);
-    if ((err = request_firmware(&firmware, buf, device)) < 0) {
-       printk(FORE200E "problem loading firmware image %s\n", fore200e->bus->model_name);
+    err = request_firmware(&firmware, buf, device);
+    if (err)
        return err;
-    }
 
     fw_data = (__le32 *) firmware->data;
     fw_size = firmware->size / sizeof(u32);
index fadba88745dcafe68f5f9a0f18a1859d7f6e6314..24c78473942b87f35213ff2b3dbb6213816d825f 100644 (file)
@@ -422,10 +422,8 @@ static int ath3k_load_patch(struct usb_device *udev)
                 le32_to_cpu(fw_version.rom_version));
 
        ret = request_firmware(&firmware, filename, &udev->dev);
-       if (ret < 0) {
-               BT_ERR("Patch file not found %s", filename);
+       if (ret)
                return ret;
-       }
 
        pt_rom_version = get_unaligned_le32(firmware->data +
                                            firmware->size - 8);
@@ -485,10 +483,8 @@ static int ath3k_load_syscfg(struct usb_device *udev)
                le32_to_cpu(fw_version.rom_version), clk_value, ".dfu");
 
        ret = request_firmware(&firmware, filename, &udev->dev);
-       if (ret < 0) {
-               BT_ERR("Configuration file not found %s", filename);
+       if (ret)
                return ret;
-       }
 
        ret = ath3k_load_fwfile(udev, firmware);
        release_firmware(firmware);
index 5b0ef7bbe8ac8778ace9baf2ba0a12f930c5ed69..e56ceaa3103b9d43bdf9e404487449b2d1b3e5dc 100644 (file)
@@ -191,7 +191,6 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
        }
 
        if (request_firmware(&firmware, "BCM2033-MD.hex", &udev->dev) < 0) {
-               BT_ERR("Mini driver request failed");
                usb_free_urb(data->urb);
                return -EIO;
        }
@@ -216,7 +215,6 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
        release_firmware(firmware);
 
        if (request_firmware(&firmware, "BCM2033-FW.bin", &udev->dev) < 0) {
-               BT_ERR("Firmware request failed");
                usb_free_urb(data->urb);
                kfree(data->buffer);
                return -EIO;
index 3bf4ec60e073608d558ff5e5b8fb8273ce043d56..1c4e0f6161eeea5959748baf665b0f2db6d98453 100644 (file)
@@ -652,10 +652,8 @@ static int bfusb_probe(struct usb_interface *intf, const struct usb_device_id *i
        skb_queue_head_init(&data->pending_q);
        skb_queue_head_init(&data->completed_q);
 
-       if (request_firmware(&firmware, "bfubase.frm", &udev->dev) < 0) {
-               BT_ERR("Firmware request failed");
+       if (request_firmware(&firmware, "bfubase.frm", &udev->dev))
                goto done;
-       }
 
        BT_DBG("firmware data %p size %zu", firmware->data, firmware->size);
 
index 8165ef2fe8777a7e119052e9d1c37848e9c6d885..5e5c18e717750eb5970e8d2b747de6fd38593342 100644 (file)
@@ -566,10 +566,8 @@ static int bt3c_open(struct bt3c_info *info)
 
        /* Load firmware */
        err = request_firmware(&firmware, "BT3CPCC.bin", &info->p_dev->dev);
-       if (err < 0) {
-               BT_ERR("Firmware request failed");
+       if (err)
                goto error;
-       }
 
        err = bt3c_load_firmware(info, firmware->data, firmware->size);
 
index d02f2c14df32545782f4d7759bb4409e482cc063..f23f738f5db6c456d57f6950f369bf13ea5ba7d7 100644 (file)
@@ -452,8 +452,6 @@ static int btmrvl_sdio_download_helper(struct btmrvl_sdio_card *card)
        ret = request_firmware(&fw_helper, card->helper,
                                                &card->func->dev);
        if ((ret < 0) || !fw_helper) {
-               BT_ERR("request_firmware(helper) failed, error code = %d",
-                                                                       ret);
                ret = -ENOENT;
                goto done;
        }
@@ -552,8 +550,6 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card)
        ret = request_firmware(&fw_firmware, card->firmware,
                                                        &card->func->dev);
        if ((ret < 0) || !fw_firmware) {
-               BT_ERR("request_firmware(firmware) failed, error code = %d",
-                                                                       ret);
                ret = -ENOENT;
                goto done;
        }
index 50aa9ba91f255c6a99f1b385ecd065cbc5541d24..bb8131604fd8a78aa986804307eb256794b22100 100644 (file)
@@ -140,11 +140,8 @@ static int dsp56k_upload(u_char __user *bin, int len)
        }
        err = request_firmware(&fw, fw_name, &pdev->dev);
        platform_device_unregister(pdev);
-       if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fw_name, err);
+       if (err)
                return err;
-       }
        if (fw->size % 3) {
                printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
                       fw->size, fw_name);
index 03ec76fc22ff191423bc354e5b5005a621d83412..dd06162f9d35e84bacbbc44edf383f038e053760 100644 (file)
@@ -1399,11 +1399,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
        const struct sdma_script_start_addrs *addr;
        unsigned short *ram_code;
 
-       if (!fw) {
-               dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
-               /* In this case we just use the ROM firmware. */
+       if (!fw)
                return;
-       }
 
        if (fw->size < sizeof(*header))
                goto err_firmware;
index 0b76352260a9fbef3c7a4115299ca130a86b22e1..06953a711525e61c5acbc37efcd2735b84a94d59 100644 (file)
@@ -79,11 +79,8 @@ int mga_warp_install_microcode(drm_mga_private_t *dev_priv)
        }
        rc = request_ihex_firmware(&fw, firmware_name, &pdev->dev);
        platform_device_unregister(pdev);
-       if (rc) {
-               DRM_ERROR("mga: Failed to load microcode \"%s\"\n",
-                         firmware_name);
+       if (rc)
                return rc;
-       }
 
        size = 0;
        where = 0;
index 157919c788e6f72261d6989a352c4f6fddf3a014..5960480ea52322d19591ae9fe4f9936a04941578 100644 (file)
@@ -1765,10 +1765,8 @@ gf100_gr_ctor_fw(struct gf100_gr *gr, const char *fwname,
        int ret;
 
        ret = nvkm_firmware_get(device, fwname, &fw);
-       if (ret) {
-               nvkm_error(subdev, "failed to load %s\n", fwname);
+       if (ret)
                return ret;
-       }
 
        fuc->size = fw->size;
        fuc->data = kmemdup(fw->data, fuc->size, GFP_KERNEL);
index 14fd83b5f497468a8764cedc4dcc98ae17b799b6..0b1c549b49b941889467258090f4ed4c08a521eb 100644 (file)
@@ -154,11 +154,8 @@ static int r128_cce_load_microcode(drm_r128_private_t *dev_priv)
        }
        rc = request_firmware(&fw, FIRMWARE_NAME, &pdev->dev);
        platform_device_unregister(pdev);
-       if (rc) {
-               printk(KERN_ERR "r128_cce: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_NAME);
+       if (rc)
                return rc;
-       }
 
        if (fw->size != 256 * 8) {
                printk(KERN_ERR
index 4b9c2d5ff6a182e898e7dce9a802c04189ebe339..62664d482629297c4a02aec4bc9bb707ba82b1ea 100644 (file)
@@ -837,10 +837,6 @@ int ni_init_microcode(struct radeon_device *rdev)
 
 out:
        if (err) {
-               if (err != -EINVAL)
-                       printk(KERN_ERR
-                              "ni_cp: Failed to load firmware \"%s\"\n",
-                              fw_name);
                release_firmware(rdev->pfp_fw);
                rdev->pfp_fw = NULL;
                release_firmware(rdev->me_fw);
index f25994b3afa633db491737d0afa9684b6a8eda67..d9e1198ac2e3f96e932774b11c6a8bba7f6e5aa5 100644 (file)
@@ -1041,10 +1041,7 @@ static int r100_cp_init_microcode(struct radeon_device *rdev)
        }
 
        err = request_firmware(&rdev->me_fw, fw_name, rdev->dev);
-       if (err) {
-               printk(KERN_ERR "radeon_cp: Failed to load firmware \"%s\"\n",
-                      fw_name);
-       } else if (rdev->me_fw->size % 8) {
+       if (err == 0 && rdev->me_fw->size % 8) {
                printk(KERN_ERR
                       "radeon_cp: Bogus length %zu in firmware \"%s\"\n",
                       rdev->me_fw->size, fw_name);
index 9247e7d207fe2e3079819f7511e43f9895b31cb9..93f3f90fc4eb118fb1fc26223ea82fa62e6568bd 100644 (file)
@@ -2599,10 +2599,6 @@ int r600_init_microcode(struct radeon_device *rdev)
 
 out:
        if (err) {
-               if (err != -EINVAL)
-                       printk(KERN_ERR
-                              "r600_cp: Failed to load firmware \"%s\"\n",
-                              fw_name);
                release_firmware(rdev->pfp_fw);
                rdev->pfp_fw = NULL;
                release_firmware(rdev->me_fw);
index c72775f2721226868604b3770b1dbe23b7456dc0..f41f076d583b51af6621cc74cfe982a68202953b 100644 (file)
@@ -406,10 +406,8 @@ int qib_sd7220_init(struct qib_devdata *dd)
        }
 
        ret = request_firmware(&fw, SD7220_FW_NAME, &dd->pcidev->dev);
-       if (ret) {
-               qib_dev_err(dd, "Failed to load IB SERDES image\n");
+       if (ret)
                goto done;
-       }
 
        /* Substitute our deduced value for was_reset */
        ret = qib_ibsd_ucode_loaded(dd->pport, fw);
index 5af7907d0af4dd6ab79639ee91287cdf0bc90202..d39d2410d247b709fec330ff94e33336384ec58e 100644 (file)
@@ -2193,10 +2193,8 @@ static int mxt_load_fw(struct device *dev, const char *fn)
        int ret;
 
        ret = request_firmware(&fw, fn, dev);
-       if (ret) {
-               dev_err(dev, "Unable to open firmware %s\n", fn);
+       if (ret)
                return ret;
-       }
 
        /* Check for incorrect enc file */
        ret = mxt_check_firmware_format(dev, fw);
index 9815bb4eec9c747a6f285377622ca004b2ea0373..73855b53aeb907fc579a36a004c3ea6114c41f15 100644 (file)
@@ -392,11 +392,8 @@ setup_instance(struct sfax_hw *card)
        card->isar.owner = THIS_MODULE;
 
        err = request_firmware(&firmware, "isdn/ISAR.BIN", &card->pdev->dev);
-       if (err < 0) {
-               pr_info("%s: firmware request failed %d\n",
-                       card->name, err);
+       if (err)
                goto error_fw;
-       }
        if (debug & DEBUG_HW)
                pr_notice("%s: got firmware %zu bytes\n",
                          card->name, firmware->size);
index f3a42834d7d61e34f865420befaa63ad639775a2..4ee7128aad3d0bcf765d16d965608a11934e2076 100644 (file)
@@ -1162,10 +1162,8 @@ static int smscore_load_firmware_from_file(struct smscore_device_t *coredev,
                return -EINVAL;
 
        rc = request_firmware(&fw, fw_filename, coredev->device);
-       if (rc < 0) {
-               pr_err("failed to open firmware file '%s'\n", fw_filename);
+       if (rc < 0)
                return rc;
-       }
        pr_debug("read fw %s, buffer size=0x%zx\n", fw_filename, fw->size);
        fw_buf = kmalloc(ALIGN(fw->size + sizeof(struct sms_firmware),
                         SMS_ALLOC_ALIGNMENT), GFP_KERNEL | GFP_DMA);
index 8bcde336ffd70e7f4781421cd5c2632341dd4407..4be7d54ee2ef8cafbcb3c86b48f04255ee1ddf1e 100644 (file)
@@ -1380,16 +1380,8 @@ static int af9013_download_firmware(struct af9013_state *state)
 
        /* request the firmware, this will block and timeout */
        ret = request_firmware(&fw, fw_file, state->i2c->dev.parent);
-       if (ret) {
-               dev_info(&state->i2c->dev, "%s: did not find the firmware " \
-                       "file. (%s) Please see linux/Documentation/dvb/ for " \
-                       "more details on firmware-problems. (%d)\n",
-                       KBUILD_MODNAME, fw_file, ret);
+       if (ret)
                goto err;
-       }
-
-       dev_info(&state->i2c->dev, "%s: downloading firmware from file '%s'\n",
-                       KBUILD_MODNAME, fw_file);
 
        /* calc checksum */
        for (i = 0; i < fw->size; i++)
index bb698839e477e23a07a04dbc15082cdd341d04f0..3b23ea1c57444792558d6617d676759e2361b167 100644 (file)
@@ -635,10 +635,9 @@ static int bcm3510_download_firmware(struct dvb_frontend* fe)
        int ret,i;
 
        deb_info("requesting firmware\n");
-       if ((ret = st->config->request_firmware(fe, &fw, BCM3510_DEFAULT_FIRMWARE)) < 0) {
-               err("could not load firmware (%s): %d",BCM3510_DEFAULT_FIRMWARE,ret);
+       ret = st->config->request_firmware(fe, &fw, BCM3510_DEFAULT_FIRMWARE);
+       if (ret)
                return ret;
-       }
        deb_info("got firmware: %zu\n", fw->size);
 
        b = fw->data;
index 8814f36d53fb8e33ca70aa995943381ac7e7b5d1..d4020d9c3ac3108dc9c25ce0ec1c232b587ae92a 100644 (file)
@@ -495,13 +495,8 @@ static int cx24116_firmware_ondemand(struct dvb_frontend *fe)
                        __func__, CX24116_DEFAULT_FIRMWARE);
                ret = request_firmware(&fw, CX24116_DEFAULT_FIRMWARE,
                        state->i2c->dev.parent);
-               printk(KERN_INFO "%s: Waiting for firmware upload(2)...\n",
-                       __func__);
-               if (ret) {
-                       printk(KERN_ERR "%s: No firmware uploaded "
-                               "(timeout or file not found?)\n", __func__);
+               if (ret)
                        return ret;
-               }
 
                /* Make sure we don't recurse back through here
                 * during loading */
index 445a15c2714fe62af2b22a61e1e78eef64b89d52..0bf80f8003d71f8d29e1b459f700e706bd665815 100644 (file)
@@ -905,10 +905,8 @@ static int load_firmware(struct drxd_state *state, const char *fw_name)
 {
        const struct firmware *fw;
 
-       if (request_firmware(&fw, fw_name, state->dev) < 0) {
-               printk(KERN_ERR "drxd: firmware load failure [%s]\n", fw_name);
+       if (request_firmware(&fw, fw_name, state->dev))
                return -EIO;
-       }
 
        state->microcode = kmemdup(fw->data, fw->size, GFP_KERNEL);
        if (state->microcode == NULL) {
index b975da099929e0b00afe791861b3dd556e3a8106..2e1ac411d07d6bd5a1aa951e93854246f98a3a0c 100644 (file)
@@ -6284,10 +6284,6 @@ static void load_firmware_cb(const struct firmware *fw,
 
        dprintk(1, ": %s\n", fw ? "firmware loaded" : "firmware not loaded");
        if (!fw) {
-               pr_err("Could not load firmware file %s.\n",
-                       state->microcode_name);
-               pr_info("Copy %s to your hotplug directory!\n",
-                       state->microcode_name);
                state->microcode_name = NULL;
 
                /*
index 447b518e287a305b0749c1a6128cea6232f3f1a6..0d6547032a91cd9043020e5c67da59f3fa1f5a81 100644 (file)
@@ -362,12 +362,8 @@ static int ds3000_firmware_ondemand(struct dvb_frontend *fe)
                                DS3000_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, DS3000_DEFAULT_FIRMWARE,
                                state->i2c->dev.parent);
-       printk(KERN_INFO "%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               printk(KERN_ERR "%s: No firmware uploaded (timeout or file not "
-                               "found?)\n", __func__);
+       if (ret)
                return ret;
-       }
 
        ret = ds3000_load_firmware(fe, fw);
        if (ret)
index 79c3040912ab5c24f23aff01e0cb1df482a75e34..c659e4cbaac5cc02355a881afc77ae28a9946855 100644 (file)
@@ -891,12 +891,8 @@ static int nxt2002_init(struct dvb_frontend* fe)
                 __func__, NXT2002_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, NXT2002_DEFAULT_FIRMWARE,
                               state->i2c->dev.parent);
-       pr_debug("%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               pr_err("%s: No firmware uploaded (timeout or file not found?)"
-                      "\n", __func__);
+       if (ret)
                return ret;
-       }
 
        ret = nxt2002_load_firmware(fe, fw);
        release_firmware(fw);
@@ -958,12 +954,8 @@ static int nxt2004_init(struct dvb_frontend* fe)
                 __func__, NXT2004_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, NXT2004_DEFAULT_FIRMWARE,
                               state->i2c->dev.parent);
-       pr_debug("%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               pr_err("%s: No firmware uploaded (timeout or file not found?)"
-                      "\n", __func__);
+       if (ret)
                return ret;
-       }
 
        ret = nxt2004_load_firmware(fe, fw);
        release_firmware(fw);
index a165af990672f2a2c196e4f961a0341796cd1ae2..bbfd1c1c0709e4281fc9d9341c9747c0c843220b 100644 (file)
@@ -341,11 +341,8 @@ static int or51132_set_parameters(struct dvb_frontend *fe)
                printk("or51132: Waiting for firmware upload(%s)...\n",
                       fwname);
                ret = request_firmware(&fw, fwname, state->i2c->dev.parent);
-               if (ret) {
-                       printk(KERN_WARNING "or51132: No firmware up"
-                              "loaded(timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
                ret = or51132_load_firmware(fe, fw);
                release_firmware(fw);
                if (ret) {
index e82413b975e6ff81f52b7ffe8903842c372cf94f..1d89fe8dcba186ac62d3c057fd33147866e64367 100644 (file)
@@ -375,12 +375,8 @@ static int or51211_init(struct dvb_frontend* fe)
                        OR51211_DEFAULT_FIRMWARE);
                ret = config->request_firmware(fe, &fw,
                                               OR51211_DEFAULT_FIRMWARE);
-               pr_info("Got Hotplug firmware\n");
-               if (ret) {
-                       pr_warn("No firmware uploaded "
-                               "(timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
 
                ret = or51211_load_firmware(fe, fw);
                release_firmware(fw);
index e87ac30d7fb83a772d9f924fb0d0b15c137a12ff..366326e7b30583116b04553f3ff7d26e87482c2f 100644 (file)
@@ -315,10 +315,8 @@ static int sp8870_init (struct dvb_frontend* fe)
 
        /* request the firmware, this will block until someone uploads it */
        printk("sp8870: waiting for firmware upload (%s)...\n", SP8870_DEFAULT_FIRMWARE);
-       if (state->config->request_firmware(fe, &fw, SP8870_DEFAULT_FIRMWARE)) {
-               printk("sp8870: no firmware upload (timeout or file not found?)\n");
+       if (state->config->request_firmware(fe, &fw, SP8870_DEFAULT_FIRMWARE))
                return -EIO;
-       }
 
        if (sp8870_firmware_upload(state, fw)) {
                printk("sp8870: writing firmware to device failed\n");
index 4378fe1b978e38b1d1b2dde57f0f6b73e3545f16..672db3f29eebabf949ba18ab77c8e1a201675845 100644 (file)
@@ -527,10 +527,8 @@ static int sp887x_init(struct dvb_frontend* fe)
                /* request the firmware, this will block until someone uploads it */
                printk("sp887x: waiting for firmware upload (%s)...\n", SP887X_DEFAULT_FIRMWARE);
                ret = state->config->request_firmware(fe, &fw, SP887X_DEFAULT_FIRMWARE);
-               if (ret) {
-                       printk("sp887x: no firmware upload (timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
 
                ret = sp887x_initial_setup(fe, fw);
                release_firmware(fw);
index c2bf89d0b0b049b3bdff8feaa197ec1e4caa1862..7c38ecb9aa64bc5d8755b450556555a345d07778 100644 (file)
@@ -495,8 +495,6 @@ static int tda10048_firmware_upload(struct dvb_frontend *fe)
        ret = request_firmware(&fw, TDA10048_DEFAULT_FIRMWARE,
                state->i2c->dev.parent);
        if (ret) {
-               printk(KERN_ERR "%s: Upload failed. (file not found?)\n",
-                       __func__);
                return -EIO;
        } else {
                printk(KERN_INFO "%s: firmware read %Zu bytes.\n",
index b89848313fb9c203d62a64ad0119c37956b68bea..168f95be53541ce91bd1c807c3d087e68b92a5ba 100644 (file)
@@ -401,10 +401,8 @@ static int tda10045_fwupload(struct dvb_frontend* fe)
        /* request the firmware, this will block until someone uploads it */
        printk(KERN_INFO "tda1004x: waiting for firmware upload (%s)...\n", TDA10045_DEFAULT_FIRMWARE);
        ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
-       if (ret) {
-               printk(KERN_ERR "tda1004x: no firmware upload (timeout or file not found?)\n");
+       if (ret)
                return ret;
-       }
 
        /* reset chip */
        tda1004x_write_mask(state, TDA1004X_CONFC4, 0x10, 0);
@@ -545,7 +543,6 @@ static int tda10046_fwupload(struct dvb_frontend* fe)
                        /* remain compatible to old bug: try to load with tda10045 image name */
                        ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
                        if (ret) {
-                               printk(KERN_ERR "tda1004x: no firmware upload (timeout or file not found?)\n");
                                return ret;
                        } else {
                                printk(KERN_INFO "tda1004x: please rename the firmware file to %s\n",
index 37ebeef2bbd0b2d76aace89734c542f829cc0994..091a98cc486a2ba1522465956bc046d43127df98 100644 (file)
@@ -850,12 +850,8 @@ static int tda10071_init(struct dvb_frontend *fe)
 
                /* request the firmware, this will block and timeout */
                ret = request_firmware(&fw, fw_file, &client->dev);
-               if (ret) {
-                       dev_err(&client->dev,
-                               "did not find the firmware file. (%s) Please see linux/Documentation/dvb/ for more details on firmware-problems. (%d)\n",
-                               fw_file, ret);
+               if (ret)
                        goto error;
-               }
 
                /* init */
                for (i = 0; i < ARRAY_SIZE(tab2); i++) {
index 37e052923a877d0097f23017acbc54824b58204f..18648dfc382674f668af73e638823a21a5bcab36 100644 (file)
@@ -126,10 +126,8 @@ int cx25840_loadfw(struct i2c_client *client)
        if (is_cx231xx(state) && max_buf_size > 16)
                max_buf_size = 16;
 
-       if (request_firmware(&fw, fwname, FWDEV(client)) != 0) {
-               v4l_err(client, "unable to open firmware %s\n", fwname);
+       if (request_firmware(&fw, fwname, FWDEV(client)) != 0)
                return -EINVAL;
-       }
 
        start_fw_load(client);
 
index 8a17cc0bfa0737ec80818aaa9a3bcbae05feedca..5cc0c1ade121393c9f6afeab680600121ff49148 100644 (file)
@@ -3912,10 +3912,8 @@ static int pvr_boot(struct bttv *btv)
        int rc;
 
        rc = request_firmware(&fw_entry, "hcwamc.rbf", &btv->c.pci->dev);
-       if (rc != 0) {
-               pr_warn("%d: no altera firmware [via hotplug]\n", btv->c.nr);
+       if (rc != 0)
                return rc;
-       }
        rc = pvr_altera_load(btv, fw_entry->data, fw_entry->size);
        pr_info("%d: altera firmware upload %s\n",
                btv->c.nr, (rc < 0) ? "failed" : "ok");
index a34fd082b76ed8e2216bf0bbe1f1d9a382660f8d..33067ae05d62cb35a3d6306b3a4d70831108233f 100644 (file)
@@ -85,10 +85,8 @@ int cx18_av_loadfw(struct cx18 *cx)
        int i;
        int retries1 = 0;
 
-       if (request_firmware(&fw, FWFILE, &cx->pci_dev->dev) != 0) {
-               CX18_ERR_DEV(sd, "unable to open firmware %s\n", FWFILE);
+       if (request_firmware(&fw, FWFILE, &cx->pci_dev->dev) != 0)
                return -EINVAL;
-       }
 
        /* The firmware load often has byte errors, so allow for several
           retries, both at byte level and at the firmware load level. */
index 3eac59c51231c0f97b9ae52f1dd8e35f77615427..da4aac9d2175e10a7e01a43b22f51a75df2268dd 100644 (file)
@@ -141,9 +141,7 @@ static int yuan_mpc718_mt352_reqfw(struct cx18_stream *stream,
        int ret;
 
        ret = request_firmware(fw, fn, &cx->pci_dev->dev);
-       if (ret)
-               CX18_ERR("Unable to open firmware file %s\n", fn);
-       else {
+       if (!ret) {
                size_t sz = (*fw)->size;
                if (sz < 2 || sz > 64 || (sz % 2) != 0) {
                        CX18_ERR("Firmware %s has a bad size: %lu bytes\n",
@@ -156,7 +154,7 @@ static int yuan_mpc718_mt352_reqfw(struct cx18_stream *stream,
 
        if (ret) {
                CX18_ERR("The MPC718 board variant with the MT352 DVB-T"
-                         "demodualtor will not work without it\n");
+                         "demodulator will not work without firmware\n");
                CX18_ERR("Run 'linux/Documentation/dvb/get_dvb_firmware "
                          "mpc718' if you need the firmware\n");
        }
index c6c83445f8bfb93605990d6726b9d2755d0d4f24..bc24466ffcbac2a7f09c90643e5a4770898757b0 100644 (file)
@@ -106,11 +106,8 @@ static int load_cpu_fw_direct(const char *fn, u8 __iomem *mem, struct cx18 *cx)
        u32 __iomem *dst = (u32 __iomem *)mem;
        const u32 *src;
 
-       if (request_firmware(&fw, fn, &cx->pci_dev->dev)) {
-               CX18_ERR("Unable to open firmware %s\n", fn);
-               CX18_ERR("Did you put the firmware in the hotplug firmware directory?\n");
+       if (request_firmware(&fw, fn, &cx->pci_dev->dev))
                return -ENOMEM;
-       }
 
        src = (const u32 *)fw->data;
 
@@ -151,8 +148,6 @@ static int load_apu_fw_direct(const char *fn, u8 __iomem *dst, struct cx18 *cx,
        int sz;
 
        if (request_firmware(&fw, fn, &cx->pci_dev->dev)) {
-               CX18_ERR("unable to open firmware %s\n", fn);
-               CX18_ERR("did you put the firmware in the hotplug firmware directory?\n");
                cx18_setup_page(cx, 0);
                return -ENOMEM;
        }
index 4d080da7afaf2ebf46df5c66ec0a8dfc6d468722..5a9403ed518e3ea3e9acfa0d8f6f3a101c6d3b2b 100644 (file)
@@ -931,14 +931,8 @@ static int cx23885_load_firmware(struct cx23885_dev *dev)
        retval = request_firmware(&firmware, CX23885_FIRM_IMAGE_NAME,
                                  &dev->pci->dev);
 
-       if (retval != 0) {
-               printk(KERN_ERR
-                       "ERROR: Hotplug firmware request failed (%s).\n",
-                       CX23885_FIRM_IMAGE_NAME);
-               printk(KERN_ERR "Please fix your hotplug setup, the board will "
-                       "not work without firmware loaded!\n");
+       if (retval != 0)
                return -1;
-       }
 
        if (firmware->size != CX23885_FIRM_IMAGE_SIZE) {
                printk(KERN_ERR "ERROR: Firmware size mismatch "
index 4abf50f2694f9dba6c6346912205e311ad97b342..ccdd88273e787691ba86b8ba1480435363af1de8 100644 (file)
@@ -2312,11 +2312,7 @@ void cx23885_card_setup(struct cx23885_dev *dev)
                                cinfo.rev, filename);
 
                ret = request_firmware(&fw, filename, &dev->pci->dev);
-               if (ret != 0)
-                       printk(KERN_ERR "did not find the firmware file. (%s) "
-                       "Please see linux/Documentation/dvb/ for more details "
-                       "on firmware-problems.", filename);
-               else
+               if (ret == 0)
                        altera_init(&netup_config, fw);
 
                release_firmware(fw);
index 04fe9af2a80217ed89b0bf596755b3f79c366d59..d63514bf971957568117102509adaad19992946a 100644 (file)
@@ -444,12 +444,8 @@ static int blackbird_load_firmware(struct cx8802_dev *dev)
                                  &dev->pci->dev);
 
 
-       if (retval != 0) {
-               pr_err("Hotplug firmware request failed (%s).\n",
-                       CX2341X_FIRM_ENC_FILENAME);
-               pr_err("Please fix your hotplug setup, the board will not work without firmware loaded!\n");
+       if (retval != 0)
                return -EIO;
-       }
 
        if (firmware->size != BLACKBIRD_FIRM_IMAGE_SIZE) {
                pr_err("Firmware size mismatch (have %zd, expected %d)\n",
index 5b3095f65dce5ee38bfaa306930b6b826ea057f7..0f2b9f8b26bc5823524f717c83b8092421080583 100644 (file)
@@ -80,8 +80,6 @@ retry:
                release_firmware(fw);
                return size;
        }
-       IVTV_ERR("Unable to open firmware %s (must be %ld bytes)\n", fn, size);
-       IVTV_ERR("Did you put the firmware in the hotplug firmware directory?\n");
        return -ENOMEM;
 }
 
index 4e924e2d1638fe2d98d034f90e0263070dab1982..7bba65475be4dac2991fe696014c386a48b09f87 100644 (file)
@@ -1260,13 +1260,8 @@ static int ngene_load_firm(struct ngene *dev)
                break;
        }
 
-       if (request_firmware(&fw, fw_name, &dev->pci_dev->dev) < 0) {
-               printk(KERN_ERR DEVICE_NAME
-                       ": Could not load firmware file %s.\n", fw_name);
-               printk(KERN_INFO DEVICE_NAME
-                       ": Copy %s to your hotplug directory!\n", fw_name);
+       if (request_firmware(&fw, fw_name, &dev->pci_dev->dev))
                return -1;
-       }
        if (size == 0)
                size = fw->size;
        if (size != fw->size) {
@@ -1274,8 +1269,6 @@ static int ngene_load_firm(struct ngene *dev)
                        ": Firmware %s has invalid size!", fw_name);
                err = -1;
        } else {
-               printk(KERN_INFO DEVICE_NAME
-                       ": Loading firmware file %s.\n", fw_name);
                ngene_fw = (u8 *) fw->data;
                err = ngene_command_load_firmware(dev, ngene_fw, size);
        }
index 269e0782c7b64a36b773256cc318e99aef1059c3..2e0dacb0e70da300a2e06d6665460e576593f160 100644 (file)
@@ -420,11 +420,8 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
                        __func__, fwname);
 
                ret = request_firmware(&fw, fwname, &dev->pci->dev);
-               if (ret) {
-                       printk(KERN_ERR "%s() Upload failed. "
-                               "(file not found?)\n", __func__);
+               if (ret)
                        return -ENOMEM;
-               }
 
                printk(KERN_INFO "%s() firmware read %Zu bytes.\n",
                        __func__, fw->size);
index 382caf200ba16769d811296c3057aa2aa99edbe4..72865d07e7ab0d8b321e92c1727db4b4e6c1fc5b 100644 (file)
@@ -1531,16 +1531,9 @@ static int get_firmware(struct av7110* av7110)
        /* request the av7110 firmware, this will block until someone uploads it */
        ret = request_firmware(&fw, "dvb-ttpci-01.fw", &av7110->dev->pci->dev);
        if (ret) {
-               if (ret == -ENOENT) {
-                       printk(KERN_ERR "dvb-ttpci: could not load firmware,"
-                              " file not found: dvb-ttpci-01.fw\n");
-                       printk(KERN_ERR "dvb-ttpci: usually this should be in "
-                              "/usr/lib/hotplug/firmware or /lib/firmware\n");
-                       printk(KERN_ERR "dvb-ttpci: and can be downloaded from"
+               if (ret == -ENOENT)
+                       printk(KERN_ERR "dvb-ttpci: firmware can be downloaded from"
                               " https://linuxtv.org/download/dvb/firmware/\n");
-               } else
-                       printk(KERN_ERR "dvb-ttpci: cannot request firmware"
-                              " (error %i)\n", ret);
                return -EINVAL;
        }
 
index 0583d56ef5ef4fb66ed7350c2331eecdc8c18bbb..d5b3392692df5b9f7750604d4e1ff8c066b6362d 100644 (file)
@@ -251,11 +251,8 @@ int av7110_bootarm(struct av7110 *av7110)
        //saa7146_setgpio(dev, 3, SAA7146_GPIO_INPUT);
 
        ret = request_firmware(&fw, fw_name, &dev->pci->dev);
-       if (ret) {
-               printk(KERN_ERR "dvb-ttpci: Failed to load firmware \"%s\"\n",
-                       fw_name);
+       if (ret)
                return ret;
-       }
 
        mwdebi(av7110, DEBISWAB, DPRAM_BASE, fw->data, fw->size);
        release_firmware(fw);
index cc888713b3b63f2af8d987b9cf93f30dbde9c484..b672c497ba093cb9778bf67393e57155f1ebda37 100644 (file)
@@ -95,10 +95,8 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev)
                }
        }
 
-       if (err != 0) {
-               mfc_err("Firmware is not present in the /lib/firmware directory nor compiled in kernel\n");
+       if (err != 0)
                return -EINVAL;
-       }
        if (fw_blob->size > dev->fw_size) {
                mfc_err("MFC firmware is too big to be loaded\n");
                release_firmware(fw_blob);
index a93f681aa9d67c2f5dcb9bc6871f7239940960bd..0526624e257ce35cb41d4ce2a302010199e1d1bf 100644 (file)
@@ -514,11 +514,8 @@ static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
         * Uploading the firmware patch is not always necessary,
         * so we only print an info message.
         */
-       if (request_firmware(&fw_p, fw_name, dev)) {
-               dev_info(dev, "%s - %s not found\n", __func__, fw_name);
-
+       if (request_firmware(&fw_p, fw_name, dev))
                return 0;
-       }
 
        ptr = (__u8 *) fw_p->data;
        packet_num = ptr[0];
index 642b89c66bcb99eb04480dea00d49c51d50b3d7c..6164901cff03829375627dfb01f219fdb67100fe 100644 (file)
@@ -1249,10 +1249,8 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name)
 
        ret = request_firmware(&fw_entry, fw_name,
                                &fmdev->radio_dev->dev);
-       if (ret < 0) {
-               fmerr("Unable to read firmware(%s) content\n", fw_name);
+       if (ret)
                return ret;
-       }
        fmdbg("Firmware(%s) length : %zu bytes\n", fw_name, fw_entry->size);
 
        fw_data = (void *)fw_entry->data;
index 8d96a22647b396c5a8790775a883ff58eabce7ce..fdd1cb9a8b70305877ba96788ec8ac197e368a59 100644 (file)
@@ -1374,7 +1374,6 @@ static void load_firmware_cb(const struct firmware *fw,
 
        tuner_dbg("request_firmware_nowait(): %s\n", fw ? "OK" : "error");
        if (!fw) {
-               tuner_err("Could not load firmware %s.\n", priv->fname);
                priv->state = XC2028_NODEV;
                return;
        }
index 0310fd6ed1033ced21cf8c509666852b17c128b7..b6ab58f785cfe2da5fd4aa8a7b9d6ade5ca6041d 100644 (file)
@@ -907,11 +907,8 @@ static int apply_vp_patch(struct camera_data *cam)
        struct cpia2_command cmd;
 
        ret = request_firmware(&fw, fw_name, &cam->dev->dev);
-       if (ret) {
-               printk(KERN_ERR "cpia2: failed to load VP patch \"%s\"\n",
-                      fw_name);
+       if (ret)
                return ret;
-       }
 
        cmd.req_mode = CAMERAACCESS_TYPE_REPEAT | CAMERAACCESS_VP;
        cmd.direction = TRANSFER_WRITE;
index 29d450c15f293bed2b59dc92c207fedef5cd67c5..02f13aa5ec4aad51e9466ed60927f2be51d2d3e9 100644 (file)
@@ -999,11 +999,6 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
                                  dev->dev);
 
        if (retval != 0) {
-               dev_err(dev->dev,
-                       "ERROR: Hotplug firmware request failed (%s).\n",
-                       CX231xx_FIRM_IMAGE_NAME);
-               dev_err(dev->dev,
-                       "Please fix your hotplug setup, the board will not work without firmware loaded!\n");
                vfree(p_current_fw);
                vfree(p_buffer);
                return retval;
index 0857b56e652cf96515d34b890ff65693c5936507..87eb213b446c33c8321720553bc46073db49d003 100644 (file)
@@ -2410,12 +2410,9 @@ static int stk9090m_frontend_attach(struct dvb_usb_adapter *adap)
 
        dib9000_i2c_enumeration(&adap->dev->i2c_adap, 1, 0x10, 0x80);
 
-       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
-               deb_info("%s: Upload failed. (file not found?)\n", __func__);
+       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev))
                return -ENODEV;
-       } else {
-               deb_info("%s: firmware read %Zu bytes.\n", __func__, state->frontend_firmware->size);
-       }
+       deb_info("%s: firmware read %Zu bytes.\n", __func__, state->frontend_firmware->size);
        stk9090m_config.microcode_B_fe_size = state->frontend_firmware->size;
        stk9090m_config.microcode_B_fe_buffer = state->frontend_firmware->data;
 
@@ -2476,12 +2473,9 @@ static int nim9090md_frontend_attach(struct dvb_usb_adapter *adap)
        msleep(20);
        dib0700_set_gpio(adap->dev, GPIO0, GPIO_OUT, 1);
 
-       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
-               deb_info("%s: Upload failed. (file not found?)\n", __func__);
+       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev))
                return -EIO;
-       } else {
-               deb_info("%s: firmware read %Zu bytes.\n", __func__, state->frontend_firmware->size);
-       }
+       deb_info("%s: firmware read %Zu bytes.\n", __func__, state->frontend_firmware->size);
        nim9090md_config[0].microcode_B_fe_size = state->frontend_firmware->size;
        nim9090md_config[0].microcode_B_fe_buffer = state->frontend_firmware->data;
        nim9090md_config[1].microcode_B_fe_size = state->frontend_firmware->size;
index dd048a7c461c8ffe1884b52ca80ff2b35233adaf..376aea66a0122023dc695a1295d8ab6c777a2722 100644 (file)
@@ -80,14 +80,9 @@ int dvb_usb_download_firmware(struct usb_device *udev, struct dvb_usb_device_pro
        int ret;
        const struct firmware *fw = NULL;
 
-       if ((ret = request_firmware(&fw, props->firmware, &udev->dev)) != 0) {
-               err("did not find the firmware file. (%s) "
-                       "Please see linux/Documentation/dvb/ for more details on firmware-problems. (%d)",
-                       props->firmware,ret);
+       ret = request_firmware(&fw, props->firmware, &udev->dev);
+       if (ret)
                return ret;
-       }
-
-       info("downloading firmware from file '%s'",props->firmware);
 
        switch (props->usb_ctrl) {
                case CYPRESS_AN2135:
index 5d0384dd45b5ed1ed2e638acdddf9fe86ea2e628..f9c2b203eea23efed5d9d6d3c5bc3227936f9bb6 100644 (file)
@@ -116,20 +116,14 @@ static int gp8psk_load_bcm4500fw(struct dvb_usb_device *d)
        const u8 *ptr;
        u8 *buf;
        if ((ret = request_firmware(&fw, bcm4500_firmware,
-                                       &d->udev->dev)) != 0) {
-               err("did not find the bcm4500 firmware file. (%s) "
-                       "Please see linux/Documentation/dvb/ for more details on firmware-problems. (%d)",
-                       bcm4500_firmware,ret);
+                                       &d->udev->dev)) != 0)
                return ret;
-       }
 
        ret = -EINVAL;
 
        if (gp8psk_usb_out_op(d, LOAD_BCM4500,1,0,NULL, 0))
                goto out_rel_fw;
 
-       info("downloading bcm4500 firmware from file '%s'",bcm4500_firmware);
-
        ptr = fw->data;
        buf = kmalloc(64, GFP_KERNEL | GFP_DMA);
        if (!buf) {
index 2566d2f1c2ad0220467462524926eabcbb5c1ecc..4c557bff8aeae16e8c509c21b6dad0ac7b6fb6fa 100644 (file)
@@ -453,9 +453,6 @@ static int opera1_xilinx_load_firmware(struct usb_device *dev,
        info("start downloading fpga firmware %s",filename);
 
        if ((ret = request_firmware(&fw, filename, &dev->dev)) != 0) {
-               err("did not find the firmware file. (%s) "
-                       "Please see linux/Documentation/dvb/ for more details on firmware-problems.",
-                       filename);
                return ret;
        } else {
                p = kmalloc(fw->size, GFP_KERNEL);
index 05b1126f263ef234015261b010439f9fc6e75bc8..fc3f4dfaf67578ef08634640f9364efc1bdfe91d 100644 (file)
@@ -92,10 +92,8 @@ static int go7007_load_encoder(struct go7007 *go)
        u16 intr_val, intr_data;
 
        if (go->boot_fw == NULL) {
-               if (request_firmware(&fw_entry, fw_name, go->dev)) {
-                       v4l2_err(go, "unable to load firmware from file \"%s\"\n", fw_name);
+               if (request_firmware(&fw_entry, fw_name, go->dev))
                        return -1;
-               }
                if (fw_entry->size < 16 || memcmp(fw_entry->data, "WISGO7007FW", 11)) {
                        v4l2_err(go, "file \"%s\" does not appear to be go7007 firmware\n", fw_name);
                        release_firmware(fw_entry);
index 60bf5f0644d116f9d73e06b320740c0acaf5f786..23dc15d0a716cdfdeaa64efd3d2fea401d41bd7d 100644 (file)
@@ -1570,12 +1570,8 @@ int go7007_construct_fw_image(struct go7007 *go, u8 **fw, int *fwlen)
        default:
                return -1;
        }
-       if (request_firmware(&fw_entry, GO7007_FW_NAME, go->dev)) {
-               dev_err(go->dev,
-                       "unable to load firmware from file \"%s\"\n",
-                       GO7007_FW_NAME);
+       if (request_firmware(&fw_entry, GO7007_FW_NAME, go->dev))
                return -1;
-       }
        code = kzalloc(codespace * 2, GFP_KERNEL);
        if (code == NULL)
                goto fw_failed;
index 042f78a3128302f6615af845d6282f4b76d979e3..5623c5d550a960ee5435d7069ebcebeca17f3f03 100644 (file)
@@ -75,11 +75,8 @@ static int go7007_loader_probe(struct usb_interface *interface,
 
        dev_info(&interface->dev, "loading firmware %s\n", fw1);
 
-       if (request_firmware(&fw, fw1, &usbdev->dev)) {
-               dev_err(&interface->dev,
-                       "unable to load firmware from file \"%s\"\n", fw1);
+       if (request_firmware(&fw, fw1, &usbdev->dev))
                goto failed2;
-       }
        ret = cypress_load_firmware(usbdev, fw, CYPRESS_FX2);
        release_firmware(fw);
        if (0 != ret) {
@@ -90,11 +87,8 @@ static int go7007_loader_probe(struct usb_interface *interface,
        if (fw2 == NULL)
                return 0;
 
-       if (request_firmware(&fw, fw2, &usbdev->dev)) {
-               dev_err(&interface->dev,
-                       "unable to load firmware from file \"%s\"\n", fw2);
+       if (request_firmware(&fw, fw2, &usbdev->dev))
                goto failed2;
-       }
        ret = cypress_load_firmware(usbdev, fw, CYPRESS_FX2);
        release_firmware(fw);
        if (0 != ret) {
index 103f6c4236b0789d9eb621eb17efd77a5d46c63e..b8a10b58e69815a36a526ed4305de7143ddb32ed 100644 (file)
@@ -244,10 +244,8 @@ static int sd_init(struct gspca_dev *gspca_dev)
 
        ret = request_ihex_firmware(&fw, VICAM_FIRMWARE,
                                    &gspca_dev->dev->dev);
-       if (ret) {
-               pr_err("Failed to load \"vicam/firmware.fw\": %d\n", ret);
+       if (ret)
                return ret;
-       }
 
        firmware_buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
        if (!firmware_buf) {
index fe20fe4f2330d8c05c1006bc33edc39b2ac07738..61b7563129829106a210a12a4d823242d0080c80 100644 (file)
@@ -1382,29 +1382,6 @@ static int pvr2_locate_firmware(struct pvr2_hdw *hdw,
                           "request_firmware fatal error with code=%d",ret);
                return ret;
        }
-       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                  "***WARNING***"
-                  " Device %s firmware"
-                  " seems to be missing.",
-                  fwtypename);
-       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                  "Did you install the pvrusb2 firmware files"
-                  " in their proper location?");
-       if (fwcount == 1) {
-               pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                          "request_firmware unable to locate %s file %s",
-                          fwtypename,fwnames[0]);
-       } else {
-               pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                          "request_firmware unable to locate"
-                          " one of the following %s files:",
-                          fwtypename);
-               for (idx = 0; idx < fwcount; idx++) {
-                       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                                  "request_firmware: Failed to find %s",
-                                  fwnames[idx]);
-               }
-       }
        return ret;
 }
 
index 43ba71a7d02b8f4fbe0619ca8fbdbcaf25019802..8d1b3aa6a4d475dfba106f966d0447025a447863 100644 (file)
@@ -2302,10 +2302,8 @@ static int s2255_probe(struct usb_interface *interface,
        }
        /* load the first chunk */
        if (request_firmware(&dev->fw_data->fw,
-                            FIRMWARE_FILE_NAME, &dev->udev->dev)) {
-               dev_err(&interface->dev, "sensoray 2255 failed to get firmware\n");
+                            FIRMWARE_FILE_NAME, &dev->udev->dev))
                goto errorREQFW;
-       }
        /* check the firmware is valid */
        fw_size = dev->fw_data->fw->size;
        pdata = (__le32 *) &dev->fw_data->fw->data[fw_size - 8];
index d52d4a8d39ade993647cc79fe0ed8a26116d416e..4b48545b08e24e245ab5e3cf51233e469fbc0d1b 100644 (file)
@@ -296,10 +296,8 @@ static int ttusb_boot_dsp(struct ttusb *ttusb)
 
        err = request_firmware(&fw, "ttusb-budget/dspbootcode.bin",
                               &ttusb->dev->dev);
-       if (err) {
-               printk(KERN_ERR "ttusb-budget: failed to request firmware\n");
+       if (err)
                return err;
-       }
 
        /* BootBlock */
        b[0] = 0xaa;
index 4e36e24cb3a6d758f722250e47c65d2dce3e988b..51d72b0ec0ffae17207e420af97fe19712355c02 100644 (file)
@@ -1290,11 +1290,8 @@ static int ttusb_dec_boot_dsp(struct ttusb_dec *dec)
        dprintk("%s\n", __func__);
 
        result = request_firmware(&fw_entry, dec->firmware_name, &dec->udev->dev);
-       if (result) {
-               printk(KERN_ERR "%s: Firmware (%s) unavailable.\n",
-                      __func__, dec->firmware_name);
+       if (result)
                return result;
-       }
 
        firmware = fw_entry->data;
        firmware_size = fw_entry->size;
index bf0d7708beac59e2723d774ceb4297b2e2700669..af5ce12ffec412b986d53874c82f082db5ceb07d 100644 (file)
@@ -302,11 +302,8 @@ static long download_firmware(struct kim_data_s *kim_gdata)
            request_firmware(&kim_gdata->fw_entry, bts_scr_name,
                             &kim_gdata->kim_pdev->dev);
        if (unlikely((err != 0) || (kim_gdata->fw_entry->data == NULL) ||
-                    (kim_gdata->fw_entry->size == 0))) {
-               pr_err(" request_firmware failed(errno %ld) for %s", err,
-                          bts_scr_name);
+                    (kim_gdata->fw_entry->size == 0)))
                return -EINVAL;
-       }
        ptr = (void *)kim_gdata->fw_entry->data;
        len = kim_gdata->fw_entry->size;
        /* bts_header to remove out magic number and
index 52fe50725d749665b629ad9a78e6447d14b60cf4..13b5a50c4704f28997e7c2b5d63e99e2a5cb65f2 100644 (file)
@@ -237,11 +237,8 @@ int softing_load_app_fw(const char *file, struct softing *card)
        int8_t type_end = 0, type_entrypoint = 0;
 
        ret = request_firmware(&fw, file, &card->pdev->dev);
-       if (ret) {
-               dev_alert(&card->pdev->dev, "request_firmware(%s) got %i\n",
-                       file, ret);
+       if (ret)
                return ret;
-       }
        dev_dbg(&card->pdev->dev, "firmware(%s) got %lu bytes\n",
                file, (unsigned long)fw->size);
        /* parse the firmware */
index 8f8418d2ac4ad07016c37e6d5cb255e2b9709b85..66df9e943ac434f2001a31f565871c565ee63567 100644 (file)
@@ -1279,11 +1279,8 @@ typhoon_request_firmware(struct typhoon *tp)
                return 0;
 
        err = request_firmware(&typhoon_fw, FIRMWARE_NAME, &tp->pdev->dev);
-       if (err) {
-               netdev_err(tp->dev, "Failed to load firmware \"%s\"\n",
-                          FIRMWARE_NAME);
+       if (err)
                return err;
-       }
 
        image_data = typhoon_fw->data;
        remaining = typhoon_fw->size;
index 1d1069641d81f3a2dbd405a66a3cf5de044fccb4..8c8517301731dd40ef218229998cc3faf5cc981f 100644 (file)
@@ -1016,11 +1016,8 @@ static int netdev_open(struct net_device *dev)
 #endif /* VLAN_SUPPORT */
 
        retval = request_firmware(&fw_rx, FIRMWARE_RX, &np->pci_dev->dev);
-       if (retval) {
-               printk(KERN_ERR "starfire: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_RX);
+       if (retval)
                goto out_init;
-       }
        if (fw_rx->size % 4) {
                printk(KERN_ERR "starfire: bogus length %zu in \"%s\"\n",
                       fw_rx->size, FIRMWARE_RX);
@@ -1028,11 +1025,8 @@ static int netdev_open(struct net_device *dev)
                goto out_rx;
        }
        retval = request_firmware(&fw_tx, FIRMWARE_TX, &np->pci_dev->dev);
-       if (retval) {
-               printk(KERN_ERR "starfire: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_TX);
+       if (retval)
                goto out_rx;
-       }
        if (fw_tx->size % 4) {
                printk(KERN_ERR "starfire: bogus length %zu in \"%s\"\n",
                       fw_tx->size, FIRMWARE_TX);
index b90a26b13fdf22a61b08b311a4f53dbd77f81a6b..30a1fd3c87260baae6e6440ff2b01eb86afb4054 100644 (file)
@@ -2888,11 +2888,8 @@ static int ace_load_firmware(struct net_device *dev)
                fw_name = "acenic/tg1.bin";
 
        ret = request_firmware(&fw, fw_name, &ap->pdev->dev);
-       if (ret) {
-               printk(KERN_ERR "%s: Failed to load firmware \"%s\"\n",
-                      ap->name, fw_name);
+       if (ret)
                return ret;
-       }
 
        fw_data = (void *)fw->data;
 
index 2c850a92ab1540e7f4a085e2a8f860956ae86f9e..8494b845e2c8edc4f46832cd02a08b3a26b73fa0 100644 (file)
@@ -3721,16 +3721,13 @@ static int bnx2_request_uncached_firmware(struct bnx2 *bp)
        }
 
        rc = request_firmware(&bp->mips_firmware, mips_fw_file, &bp->pdev->dev);
-       if (rc) {
-               pr_err("Can't load firmware file \"%s\"\n", mips_fw_file);
+       if (rc)
                goto out;
-       }
 
        rc = request_firmware(&bp->rv2p_firmware, rv2p_fw_file, &bp->pdev->dev);
-       if (rc) {
-               pr_err("Can't load firmware file \"%s\"\n", rv2p_fw_file);
+       if (rc)
                goto err_release_mips_firmware;
-       }
+
        mips_fw = (const struct bnx2_mips_fw_file *) bp->mips_firmware->data;
        rv2p_fw = (const struct bnx2_rv2p_fw_file *) bp->rv2p_firmware->data;
        if (bp->mips_firmware->size < sizeof(*mips_fw) ||
index fa3386bb14f7317c6a3c64fdf075c379c5cc2643..2f11a63ebff4c2e4d659bdad376c82bb7c59130d 100644 (file)
@@ -13422,11 +13422,8 @@ static int bnx2x_init_firmware(struct bnx2x *bp)
        BNX2X_DEV_INFO("Loading %s\n", fw_file_name);
 
        rc = request_firmware(&bp->firmware, fw_file_name, &bp->pdev->dev);
-       if (rc) {
-               BNX2X_ERR("Can't load firmware file %s\n",
-                         fw_file_name);
+       if (rc)
                goto request_firmware_exit;
-       }
 
        rc = bnx2x_check_firmware(bp);
        if (rc) {
index ea967df4b202edbc71a4402f23ab62e41ee06f28..014c076535cfa7475ea539ff6ef2ca912be5899c 100644 (file)
@@ -11346,11 +11346,8 @@ static int tg3_request_firmware(struct tg3 *tp)
 {
        const struct tg3_firmware_hdr *fw_hdr;
 
-       if (request_firmware(&tp->fw, tp->fw_needed, &tp->pdev->dev)) {
-               netdev_err(tp->dev, "Failed to load firmware \"%s\"\n",
-                          tp->fw_needed);
+       if (request_firmware(&tp->fw, tp->fw_needed, &tp->pdev->dev))
                return -ENOENT;
-       }
 
        fw_hdr = (struct tg3_firmware_hdr *)tp->fw->data;
 
index 2e7fb97883dc739959af77d9c0567b69da5d38c9..0f9ae5be8b6f476792f4e39d258fa8dd0208493e 100644 (file)
@@ -32,10 +32,8 @@ cna_read_firmware(struct pci_dev *pdev, u32 **bfi_image,
        const struct firmware *fw;
        u32 n;
 
-       if (request_firmware(&fw, fw_name, &pdev->dev)) {
-               dev_alert(&pdev->dev, "can't load firmware %s\n", fw_name);
+       if (request_firmware(&fw, fw_name, &pdev->dev))
                goto error;
-       }
 
        *bfi_image = (u32 *)fw->data;
        *bfi_image_size = fw->size/sizeof(u32);
index 43da891fab97e7f16b572dd67f3fc6aa9020a1fb..825c839e3ff52237f7033e4a41e7f68e8fa3bfd8 100644 (file)
@@ -1037,12 +1037,8 @@ int t3_get_edc_fw(struct cphy *phy, int edc_idx, int size)
        fw_name = get_edc_fw_name(edc_idx);
        if (fw_name)
                ret = request_firmware(&fw, fw_name, &adapter->pdev->dev);
-       if (ret < 0) {
-               dev_err(&adapter->pdev->dev,
-                       "could not upgrade firmware: unable to load %s\n",
-                       fw_name);
+       if (ret)
                return ret;
-       }
 
        /* check size, take checksum in account */
        if (fw->size > size + 4) {
@@ -1079,11 +1075,8 @@ static int upgrade_fw(struct adapter *adap)
        struct device *dev = &adap->pdev->dev;
 
        ret = request_firmware(&fw, FW_FNAME, dev);
-       if (ret < 0) {
-               dev_err(dev, "could not upgrade firmware: unable to load %s\n",
-                       FW_FNAME);
+       if (ret)
                return ret;
-       }
        ret = t3_load_fw(adap, fw->data, fw->size);
        release_firmware(fw);
 
@@ -1128,11 +1121,8 @@ static int update_tpsram(struct adapter *adap)
        snprintf(buf, sizeof(buf), TPSRAM_NAME, rev);
 
        ret = request_firmware(&tpsram, buf, dev);
-       if (ret < 0) {
-               dev_err(dev, "could not load TP SRAM: unable to load %s\n",
-                       buf);
+       if (ret)
                return ret;
-       }
 
        ret = t3_check_tpsram(adap, tpsram->data, tpsram->size);
        if (ret)
index 068789e694c9b310ca6fd541a2be90f6c5059e36..b1ee1a329d420f1f1fab4857baedad54be43ca75 100644 (file)
@@ -1290,9 +1290,6 @@ static const struct firmware *e100_request_firmware(struct nic *nic)
 
        if (err) {
                if (required) {
-                       netif_err(nic, probe, nic->netdev,
-                                 "Failed to load firmware \"%s\": %d\n",
-                                 fw_name, err);
                        return ERR_PTR(err);
                } else {
                        netif_info(nic, probe, nic->netdev,
index 6d1a956e3f779d57e83a8fd40a5136919231df2c..98919d5c0d4995f77a371d5402e4c2c9489733b6 100644 (file)
@@ -596,8 +596,6 @@ static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, u32 * size)
        unsigned i;
 
        if ((status = request_firmware(&fw, mgp->fw_name, dev)) < 0) {
-               dev_err(dev, "Unable to load %s firmware image via hotplug\n",
-                       mgp->fw_name);
                status = -EINVAL;
                goto abort_with_nothing;
        }
index db3c696d7002ad921bbf8d4d3257f7e738c36c07..ef953c6253aba8a0d13e49903b9af9b7c97dccf7 100644 (file)
@@ -647,10 +647,8 @@ static int osi_load_firmware(struct pcmcia_device *link)
        int i, err;
 
        err = request_firmware(&fw, FIRMWARE_NAME, &link->dev);
-       if (err) {
-               pr_err("Failed to load firmware \"%s\"\n", FIRMWARE_NAME);
+       if (err)
                return err;
-       }
 
        /* Download the Seven of Diamonds firmware */
        for (i = 0; i < fw->size; i++) {
index 062bce9acde6f555794376cc25e24981033e0868..008af778a656edde37396aa1d44b042d0d2bd0ed 100644 (file)
@@ -816,11 +816,8 @@ static void cas_saturn_firmware_init(struct cas *cp)
                return;
 
        err = request_firmware(&fw, fw_name, &cp->pdev->dev);
-       if (err) {
-               pr_err("Failed to load firmware \"%s\"\n",
-                      fw_name);
+       if (err)
                return;
-       }
        if (fw->size < 2) {
                pr_err("bogus length %zu in \"%s\"\n",
                       fw->size, fw_name);
index aaff07c10058520fdba0b9e419bc95d8219a381c..ccda800ac7d58a484b76394144efb359087c618f 100644 (file)
@@ -372,11 +372,8 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate,
                }
                err = request_firmware(&fw, fw_name[predef], &pdev->dev);
                platform_device_unregister(pdev);
-               if (err) {
-                       printk(KERN_ERR "Failed to load firmware \"%s\"\n",
-                              fw_name[predef]);
+               if (err)
                        return NULL;
-               }
                if (fw->size != YAM_FPGA_SIZE) {
                        printk(KERN_ERR "Bogus length %zu in firmware \"%s\"\n",
                               fw->size, fw_name[predef]);
index 528b9c9c4e60bc2e397b3a1c489a5639d986af9a..8bdbad0e87c50fff8abb2321eca8ea14658e6f4e 100644 (file)
@@ -396,10 +396,8 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth,
        int ret;
 
        ret = request_firmware(&fw, fwname, &kaweth->dev->dev);
-       if (ret) {
-               dev_err(&kaweth->intf->dev, "Firmware request failed\n");
+       if (ret)
                return ret;
-       }
 
        if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) {
                dev_err(&kaweth->intf->dev, "Firmware too big: %zu\n",
index c9c711dcd0e6bb9d7ce988f42bc7e6dd7877a37b..3aa30f3d92247e6bcd6725f2db00039d3ebf4a68 100644 (file)
@@ -1582,11 +1582,8 @@ int i2400m_dev_bootstrap(struct i2400m *i2400m, enum i2400m_bri flags)
                }
                d_printf(1, dev, "trying firmware %s (%d)\n", fw_name, itr);
                ret = request_firmware(&fw, fw_name, dev);
-               if (ret < 0) {
-                       dev_err(dev, "fw %s: cannot load file: %d\n",
-                               fw_name, ret);
+               if (ret)
                        continue;
-               }
                i2400m->fw_name = fw_name;
                ret = i2400m_fw_bootstrap(i2400m, fw, flags);
                release_firmware(fw);
@@ -1629,8 +1626,6 @@ void i2400m_fw_cache(struct i2400m *i2400m)
        kref_init(&i2400m_fw->kref);
        result = request_firmware(&i2400m_fw->fw, i2400m->fw_name, dev);
        if (result < 0) {
-               dev_err(dev, "firmware %s: failed to cache: %d\n",
-                       i2400m->fw_name, result);
                kfree(i2400m_fw);
                i2400m_fw = (void *) ~0;
        } else
index e1c338cb9cb52db354df0f3ae417fe69da72b6b1..9696802215b5c15b93053878a316f7cf7a0b25e7 100644 (file)
@@ -1160,9 +1160,6 @@ static void ath9k_hif_usb_firmware_cb(const struct firmware *fw, void *context)
                if (!ret)
                        return;
 
-               dev_err(&hif_dev->udev->dev,
-                       "ath9k_htc: Failed to get firmware %s\n",
-                       hif_dev->fw_name);
                goto err_fw;
        }
 
index 76842e6ca38e64c516c29a44699442b5987864c6..e62f5c89539f2f4be404f68ef4d98bb586c868dd 100644 (file)
@@ -1033,7 +1033,6 @@ static void carl9170_usb_firmware_step2(const struct firmware *fw,
                return;
        }
 
-       dev_err(&ar->udev->dev, "firmware not found.\n");
        carl9170_usb_firmware_failed(ar);
 }
 
index 0e180677c7fc5dc6030f7d577ce16eb14eb03999..8fdf0285bb9678f715a5ddd8678c68dc9d5ec96b 100644 (file)
@@ -1622,13 +1622,8 @@ static struct fwentry *at76_load_firmware(struct usb_device *udev,
 
        at76_dbg(DBG_FW, "downloading firmware %s", fwe->fwname);
        ret = request_firmware(&fwe->fw, fwe->fwname, &udev->dev);
-       if (ret < 0) {
-               dev_err(&udev->dev, "firmware %s not found!\n",
-                       fwe->fwname);
-               dev_err(&udev->dev,
-                       "you may need to download the firmware from http://developer.berlios.de/projects/at76c503a/\n");
+       if (ret)
                goto exit;
-       }
 
        at76_dbg(DBG_FW, "got it.");
        fwh = (struct at76_fw_header *)(fwe->fw->data);
index bf2e9a083c0c31be65dc3f5c33e5a71f0015b1d3..2394e546a352edce0b9faab9fce557859c7a9aef 100644 (file)
@@ -3917,12 +3917,8 @@ static int reset_atmel_card(struct net_device *dev)
                                        strcpy(priv->firmware_id, "atmel_at76c502.bin");
                                }
                                err = request_firmware(&fw_entry, priv->firmware_id, priv->sys_dev);
-                               if (err != 0) {
-                                       printk(KERN_ALERT
-                                              "%s: firmware %s is missing, cannot continue.\n",
-                                              dev->name, priv->firmware_id);
+                               if (err != 0)
                                        return err;
-                               }
                        } else {
                                int fw_index = 0;
                                int success = 0;
index 6e5d9095b1956c1d792725591fe79a75fe676f38..d6acff6f519fd9844ecaaf0184db0e2f77149f72 100644 (file)
@@ -2253,19 +2253,8 @@ int b43_do_request_fw(struct b43_request_fw_context *ctx,
        }
        err = request_firmware(&ctx->blob, ctx->fwname,
                               ctx->dev->dev->dev);
-       if (err == -ENOENT) {
-               snprintf(ctx->errors[ctx->req_type],
-                        sizeof(ctx->errors[ctx->req_type]),
-                        "Firmware file \"%s\" not found\n",
-                        ctx->fwname);
-               return err;
-       } else if (err) {
-               snprintf(ctx->errors[ctx->req_type],
-                        sizeof(ctx->errors[ctx->req_type]),
-                        "Firmware file \"%s\" request failed (err=%d)\n",
-                        ctx->fwname, err);
+       if (err)
                return err;
-       }
 fw_ready:
        if (ctx->blob->size < sizeof(struct b43_fw_header))
                goto err_format;
index 83770d2ea057875ddd75ffb312e9b2f3d28e5e9f..a5e06219a9e41a89c797fef91a60a31bebbc52cc 100644 (file)
@@ -1554,11 +1554,8 @@ static int do_request_fw(struct b43legacy_wldev *dev,
        } else {
                err = request_firmware(fw, path, dev->dev->dev);
        }
-       if (err) {
-               b43legacyerr(dev->wl, "Firmware file \"%s\" not found "
-                      "or load failed.\n", path);
+       if (err)
                return err;
-       }
        if ((*fw)->size < sizeof(struct b43legacy_fw_header))
                goto err_format;
        hdr = (struct b43legacy_fw_header *)((*fw)->data);
index 7c2a9a9bc372c19502d3bf1d7091ccbd4654b061..896fb00b0220edf377af7f161da7e3b6b4b812d9 100644 (file)
@@ -378,19 +378,13 @@ static int brcms_request_fw(struct brcms_info *wl, struct bcma_device *pdev)
                sprintf(fw_name, "%s-%d.fw", brcms_firmwares[i],
                        UCODE_LOADER_API_VER);
                status = request_firmware(&wl->fw.fw_bin[i], fw_name, device);
-               if (status) {
-                       wiphy_err(wl->wiphy, "%s: fail to load firmware %s\n",
-                                 KBUILD_MODNAME, fw_name);
+               if (status)
                        return status;
-               }
                sprintf(fw_name, "%s_hdr-%d.fw", brcms_firmwares[i],
                        UCODE_LOADER_API_VER);
                status = request_firmware(&wl->fw.fw_hdr[i], fw_name, device);
-               if (status) {
-                       wiphy_err(wl->wiphy, "%s: fail to load firmware %s\n",
-                                 KBUILD_MODNAME, fw_name);
+               if (status)
                        return status;
-               }
                wl->fw.hdr_num_entries[i] =
                    wl->fw.fw_hdr[i]->size / (sizeof(struct firmware_hdr));
        }
index bfa542c8d6f1a2b4f98ac2c419326ceb3ac7a17d..07c18b6067a184a57deba603c80b22d2d6bce89a 100644 (file)
@@ -8418,12 +8418,8 @@ static int ipw2100_get_firmware(struct ipw2100_priv *priv,
 
        rc = request_firmware(&fw->fw_entry, fw_name, &priv->pci_dev->dev);
 
-       if (rc < 0) {
-               printk(KERN_ERR DRV_NAME ": "
-                      "%s: Firmware '%s' not available or load failed.\n",
-                      priv->net_dev->name, fw_name);
+       if (rc)
                return rc;
-       }
        IPW_DEBUG_INFO("firmware data %p size %zd\n", fw->fw_entry->data,
                       fw->fw_entry->size);
 
index bfd68612a535d6a8ec39307492131521e489c677..496933184a93f81ae6a24dd28da706db4f09de21 100644 (file)
@@ -3418,10 +3418,8 @@ static int ipw_get_fw(struct ipw_priv *priv,
 
        /* ask firmware_class module to get the boot firmware off disk */
        rc = request_firmware(raw, name, &priv->pci_dev->dev);
-       if (rc < 0) {
-               IPW_ERROR("%s request_firmware failed: Reason %d\n", name, rc);
+       if (rc)
                return rc;
-       }
 
        if ((*raw)->size < sizeof(*fw)) {
                IPW_ERROR("%s is too small (%zd)\n", name, (*raw)->size);
index 466912eb2d874a667fff2394022a748f943d3712..edc5ac634d2c8ba123bad9ebba249436e8cee515 100644 (file)
@@ -1861,7 +1861,6 @@ il3945_read_ucode(struct il_priv *il)
                sprintf(buf, "%s%u%s", name_pre, idx, ".ucode");
                ret = request_firmware(&ucode_raw, buf, &il->pci_dev->dev);
                if (ret < 0) {
-                       IL_ERR("%s firmware file req failed: %d\n", buf, ret);
                        if (ret == -ENOENT)
                                continue;
                        else
index 45b2f679e4d8ec624be0090081aad2cbab2bec5a..44f2079b2e09d1569263fc34d6df27acc323006f 100644 (file)
@@ -224,10 +224,8 @@ static int iwl_request_firmware(struct iwl_drv *drv, bool first)
                sprintf(tag, "%d", drv->fw_index);
        }
 
-       if (drv->fw_index < drv->cfg->ucode_api_min) {
-               IWL_ERR(drv, "no suitable firmware found!\n");
+       if (drv->fw_index < drv->cfg->ucode_api_min)
                return -ENOENT;
-       }
 
        snprintf(drv->firmware_name, sizeof(drv->firmware_name), "%s%s.ucode",
                 name_pre, tag);
index 400a3521764406df48dbde06c5074ee298dd6c69..2559f7f1252c2bb8ba601bf0c780216c116659f5 100644 (file)
@@ -132,7 +132,6 @@ orinoco_dl_firmware(struct orinoco_private *priv,
                err = request_firmware(&fw_entry, firmware, priv->dev);
 
                if (err) {
-                       dev_err(dev, "Cannot find firmware %s\n", firmware);
                        err = -ENOENT;
                        goto free;
                }
@@ -292,10 +291,8 @@ symbol_dl_firmware(struct orinoco_private *priv,
        const struct firmware *fw_entry;
 
        if (!orinoco_cached_fw_get(priv, true)) {
-               if (request_firmware(&fw_entry, fw->pri_fw, priv->dev) != 0) {
-                       dev_err(dev, "Cannot find firmware: %s\n", fw->pri_fw);
+               if (request_firmware(&fw_entry, fw->pri_fw, priv->dev) != 0)
                        return -ENOENT;
-               }
        } else
                fw_entry = orinoco_cached_fw_get(priv, true);
 
@@ -311,10 +308,8 @@ symbol_dl_firmware(struct orinoco_private *priv,
        }
 
        if (!orinoco_cached_fw_get(priv, false)) {
-               if (request_firmware(&fw_entry, fw->sta_fw, priv->dev) != 0) {
-                       dev_err(dev, "Cannot find firmware: %s\n", fw->sta_fw);
+               if (request_firmware(&fw_entry, fw->sta_fw, priv->dev) != 0)
                        return -ENOENT;
-               }
        } else
                fw_entry = orinoco_cached_fw_get(priv, false);
 
index 56f109bc83945d351e35888dd1091fcd6c42ac28..f4388b7e793253b01aef0e7ad981705c47935d10 100644 (file)
@@ -1669,7 +1669,6 @@ static int ezusb_probe(struct usb_interface *interface,
                if (ezusb_firmware_download(upriv, &firmware) < 0)
                        goto error;
        } else {
-               err("No firmware to download");
                goto error;
        }
 
index 27a49068d32d0a71e90b69c3a3b0289be956ff94..a12c388e3723f2becf21b769c0ad538fd8da9997 100644 (file)
@@ -499,7 +499,6 @@ static void p54p_firmware_step2(const struct firmware *fw,
        int err;
 
        if (!fw) {
-               dev_err(&pdev->dev, "Cannot find firmware (isl3886pci)\n");
                err = -ENOENT;
                goto out;
        }
index 7ab2f43ab42512e7da0c87c37574b8ed534f2b08..d2700334ccf7b0cb974cf8b10fd28444889c0bea 100644 (file)
@@ -170,10 +170,8 @@ static int p54spi_request_firmware(struct ieee80211_hw *dev)
        /* FIXME: should driver use it's own struct device? */
        ret = request_firmware(&priv->firmware, "3826.arm", &priv->spi->dev);
 
-       if (ret < 0) {
-               dev_err(&priv->spi->dev, "request_firmware() failed: %d", ret);
+       if (ret)
                return ret;
-       }
 
        ret = p54_parse_firmware(dev, priv->firmware);
        if (ret) {
index 043bd1c23c19efb6997c33865e41059011052a46..e44f623394f89d204190eade134cd78b0a144138 100644 (file)
@@ -929,7 +929,6 @@ static void p54u_load_firmware_cb(const struct firmware *firmware,
                err = p54u_start_ops(priv);
        } else {
                err = -ENOENT;
-               dev_err(&udev->dev, "Firmware not found.\n");
        }
 
        if (err) {
index 84a42012aeae096806eb0900561f12803707d448..9e8298929e3105b47441e899d291885ff1653347 100644 (file)
@@ -92,12 +92,9 @@ isl_upload_firmware(islpci_private *priv)
                const u32 *fw_ptr;
 
                rc = request_firmware(&fw_entry, priv->firmware, PRISM_FW_PDEV);
-               if (rc) {
-                       printk(KERN_ERR
-                              "%s: request_firmware() failed for '%s'\n",
-                              "prism54", priv->firmware);
+               if (rc)
                        return rc;
-               }
+
                /* prepare the Direct Memory Base register */
                reg = ISL38XX_DEV_FIRMWARE_ADDRES;
 
index 799a2efe57937241223aafcf3793586f7304346f..02b103a44fcfee18056c00b04c42f84a78f8a49e 100644 (file)
@@ -824,8 +824,6 @@ static int if_usb_prog_firmware(struct if_usb_card *cardp)
        kernel_param_lock(THIS_MODULE);
        ret = request_firmware(&cardp->fw, lbtf_fw_name, &cardp->udev->dev);
        if (ret < 0) {
-               pr_err("request_firmware() failed with %#x\n", ret);
-               pr_err("firmware %s not found\n", lbtf_fw_name);
                kernel_param_unlock(THIS_MODULE);
                goto done;
        }
index db4925db39aa4f07d716040306d6041a037ae0a3..902a970a89b0b17d2a08e5c9c0aa4f40ceeee53e 100644 (file)
@@ -515,11 +515,8 @@ static void mwifiex_fw_dpc(const struct firmware *firmware, void *context)
        bool init_failed = false;
        struct wireless_dev *wdev;
 
-       if (!firmware) {
-               mwifiex_dbg(adapter, ERROR,
-                           "Failed to get firmware %s\n", adapter->fw_name);
+       if (!firmware)
                goto err_dnld_fw;
-       }
 
        memset(&fw, 0, sizeof(struct mwifiex_fw_image));
        adapter->firmware = firmware;
index b1b400b59d86456ae5b75a66ba2f227b3dcb8b1c..f127a1edd9b7f4c29f9eb5aec58f89397f0a1686 100644 (file)
@@ -5714,16 +5714,12 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv);
 static void mwl8k_fw_state_machine(const struct firmware *fw, void *context)
 {
        struct mwl8k_priv *priv = context;
-       struct mwl8k_device_info *di = priv->device_info;
        int rc;
 
        switch (priv->fw_state) {
        case FW_STATE_INIT:
-               if (!fw) {
-                       printk(KERN_ERR "%s: Error requesting helper fw %s\n",
-                              pci_name(priv->pdev), di->helper_image);
+               if (!fw)
                        goto fail;
-               }
                priv->fw_helper = fw;
                rc = mwl8k_request_fw(priv, priv->fw_pref, &priv->fw_ucode,
                                      true);
@@ -5758,11 +5754,8 @@ static void mwl8k_fw_state_machine(const struct firmware *fw, void *context)
                break;
 
        case FW_STATE_LOADING_ALT:
-               if (!fw) {
-                       printk(KERN_ERR "%s: Error requesting alt fw %s\n",
-                              pci_name(priv->pdev), di->helper_image);
+               if (!fw)
                        goto fail;
-               }
                priv->fw_ucode = fw;
                rc = mwl8k_firmware_load_success(priv);
                if (rc)
@@ -5800,10 +5793,8 @@ retry:
 
        /* Ask userland hotplug daemon for the device firmware */
        rc = mwl8k_request_firmware(priv, fw_image, nowait);
-       if (rc) {
-               wiphy_err(hw->wiphy, "Firmware files not found\n");
+       if (rc)
                return rc;
-       }
 
        if (nowait)
                return rc;
index 5813300f68a2c5b9cf58ec2cbdf74d70e68c1bb7..ecebea6f53874878c9dc47087354525fa42ee9c0 100644 (file)
@@ -49,10 +49,8 @@ static int rt2x00lib_request_firmware(struct rt2x00_dev *rt2x00dev)
        rt2x00_info(rt2x00dev, "Loading firmware file '%s'\n", fw_name);
 
        retval = request_firmware(&fw, fw_name, device);
-       if (retval) {
-               rt2x00_err(rt2x00dev, "Failed to request Firmware\n");
+       if (retval)
                return retval;
-       }
 
        if (!fw || !fw->size || !fw->data) {
                rt2x00_err(rt2x00dev, "Failed to read Firmware\n");
index 41f77f8a309e751be975a4ed2abdccc61fd6dc10..c0c88a2131c95debebb2689527038df56f5cbb57 100644 (file)
@@ -111,7 +111,6 @@ static void rtl_fw_do_work(const struct firmware *firmware, void *context,
                        if (!err)
                                goto found_alt;
                }
-               pr_err("Firmware %s not available\n", rtlpriv->cfg->fw_name);
                rtlpriv->max_fw_size = 0;
                return;
        }
index 31baca41ac2f4c90641bb6270d33915dd9f299b3..ad7d12ca387bcc1b9f16d0b5ce1f31874f4d1a86 100644 (file)
@@ -94,7 +94,6 @@ static void rtl92se_fw_cb(const struct firmware *firmware, void *context)
                         "Firmware callback routine entered!\n");
        complete(&rtlpriv->firmware_loading_complete);
        if (!firmware) {
-               pr_err("Firmware %s not available\n", rtlpriv->cfg->fw_name);
                rtlpriv->max_fw_size = 0;
                return;
        }
index bbf7604889b7574b926ee3ac7467b5902e15ca45..a98dea0a124c88b20a1701048225e5cd0536be03 100644 (file)
@@ -71,10 +71,8 @@ static int wl1251_fetch_firmware(struct wl1251 *wl)
 
        ret = request_firmware(&fw, WL1251_FW_NAME, dev);
 
-       if (ret < 0) {
-               wl1251_error("could not get firmware: %d", ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1251_error("firmware size is not multiple of 32 bits: %zu",
@@ -110,10 +108,8 @@ static int wl1251_fetch_nvs(struct wl1251 *wl)
 
        ret = request_firmware(&fw, WL1251_NVS_NAME, dev);
 
-       if (ret < 0) {
-               wl1251_error("could not get nvs file: %d", ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1251_error("nvs size is not multiple of 32 bits: %zu",
index 9e1f2d9c98659279d85c914247c7b7f95a62b8c7..4cb1b6119ed7070ee58f72a278f7d7b79515bb9f 100644 (file)
@@ -756,10 +756,8 @@ static int wl12xx_fetch_firmware(struct wl1271 *wl, bool plt)
 
        ret = request_firmware(&fw, fw_name, wl->dev);
 
-       if (ret < 0) {
-               wl1271_error("could not get firmware %s: %d", fw_name, ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1271_error("firmware size is not multiple of 32 bits: %zu",
index dea049b2556f337ed1f1504cef7e834882035707..df5c2616681e05a6e824669f06672061727943df 100644 (file)
@@ -65,8 +65,6 @@ static int zd1201_fw_upload(struct usb_device *dev, int apfw)
 
        err = request_firmware(&fw_entry, fwfile, &dev->dev);
        if (err) {
-               dev_err(&dev->dev, "Failed to load %s firmware file!\n", fwfile);
-               dev_err(&dev->dev, "Make sure the hotplug firmware loader is installed.\n");
                dev_err(&dev->dev, "Goto http://linux-lc100020.sourceforge.net for more info.\n");
                return err;
        }
index a912dc051111973367d7b4056f5c793004885f6d..2eea48b467cbaaaae5f99d60e1c3cb40c750b204 100644 (file)
@@ -120,16 +120,9 @@ static void int_urb_complete(struct urb *urb);
 static int request_fw_file(
        const struct firmware **fw, const char *name, struct device *device)
 {
-       int r;
-
        dev_dbg_f(device, "fw name %s\n", name);
 
-       r = request_firmware(fw, name, device);
-       if (r)
-               dev_err(device,
-                      "Could not load firmware file %s. Error number %d\n",
-                      name, r);
-       return r;
+       return request_firmware(fw, name, device);
 }
 
 static inline u16 get_bcdDevice(const struct usb_device *udev)
index febbd83e2ecd9d6a6984500eb8cc02d6690c3984..e26fb7159c271ec931dac91923f9c2e91fcc2db1 100644 (file)
@@ -4107,8 +4107,6 @@ static int AscInitAsc1000Driver(ASC_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code |= ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -4473,8 +4471,6 @@ static int AdvInitAsc3550Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -4973,8 +4969,6 @@ static int AdvInitAsc38C0800Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -5461,8 +5455,6 @@ static int AdvInitAsc38C1600Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
index 662b2321d1b0f40e73bf401925e23b81d377462a..19c1559e3c808c19a1a20967b35aa09b4ff16930 100644 (file)
@@ -384,8 +384,6 @@ static ssize_t asd_store_update_bios(struct device *dev,
                                   filename_ptr,
                                   &asd_ha->pcidev->dev);
        if (err) {
-               asd_printk("Failed to load bios image file %s, error %d\n",
-                          filename_ptr, err);
                err = FAIL_OPEN_BIOS_FILE;
                goto out1;
        }
index da1e0568510d573877c891c56e9776bbb254525e..694cd0d7712123d62e87bee002a440af16ff1b48 100644 (file)
@@ -1317,11 +1317,8 @@ int asd_init_seqs(struct asd_ha_struct *asd_ha)
 
        err = asd_request_firmware(asd_ha);
 
-       if (err) {
-               asd_printk("Failed to load sequencer firmware file %s, error %d\n",
-                          SAS_RAZOR_SEQUENCER_FW_FILE, err);
+       if (err)
                return err;
-       }
 
        err = asd_seq_download_seqs(asd_ha);
        if (err) {
index 9d253cb83ee762692c1ec0f56303f3c7fc8b416e..9258cf87db6f644024fcdfd1e8f53cd9b3c5f0a5 100644 (file)
@@ -1758,7 +1758,6 @@ bfad_read_firmware(struct pci_dev *pdev, u32 **bfi_image,
        const struct firmware *fw;
 
        if (request_firmware(&fw, fw_name, &pdev->dev)) {
-               printk(KERN_ALERT "Can't locate firmware %s\n", fw_name);
                *bfi_image = NULL;
                goto out;
        }
index 17d04c702e1ba13a1642d36a1de98fb7831665eb..1033a105be9e3298f679a27dce077b62951853b5 100644 (file)
@@ -4020,10 +4020,8 @@ static ssize_t ipr_store_update_fw(struct device *dev,
        if (endline)
                *endline = '\0';
 
-       if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev)) {
-               dev_err(&ioa_cfg->pdev->dev, "Firmware file %s not found\n", fname);
+       if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev))
                return -EIO;
-       }
 
        image_hdr = (struct ipr_ucode_image_header *)fw_entry->data;
 
index be8269c8d127959ee5c9021cab724577acde5fff..d7770a607326ff707faf2dd128024b193aa4e83f 100644 (file)
@@ -685,10 +685,6 @@ static ssize_t pm8001_store_update_fw(struct device *cdev,
                               pm8001_ha->dev);
 
        if (ret) {
-               PM8001_FAIL_DBG(pm8001_ha,
-                       pm8001_printk(
-                       "Failed to load firmware image file %s, error %d\n",
-                       filename_ptr, ret));
                pm8001_ha->fw_status = FAIL_OPEN_BIOS_FILE;
                goto out;
        }
index 634254a523013a557327a7b38825924de7e71b6c..1486dcae66230180c6d212faf7b46973fe3969bf 100644 (file)
@@ -1552,8 +1552,6 @@ qla1280_request_firmware(struct scsi_qla_host *ha)
        err = request_firmware(&fw, fwname, &ha->pdev->dev);
 
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                fw = ERR_PTR(err);
                goto unlock;
        }
index 5b09296b46a3058f9c938990274d158b508af884..2cb785e61b61bdabc1b53e2f246b5b68770b40b8 100644 (file)
@@ -5656,8 +5656,6 @@ qla2x00_load_risc(scsi_qla_host_t *vha, uint32_t *srisc_addr)
        /* Load firmware blob. */
        blob = qla2x00_request_firmware(vha);
        if (!blob) {
-               ql_log(ql_log_info, vha, 0x0083,
-                   "Firmware image unavailable.\n");
                ql_log(ql_log_info, vha, 0x0084,
                    "Firmware images can be retrieved from: "QLA_FW_URL ".\n");
                return QLA_FUNCTION_FAILED;
@@ -5759,8 +5757,6 @@ qla24xx_load_risc_blob(scsi_qla_host_t *vha, uint32_t *srisc_addr)
        /* Load firmware blob. */
        blob = qla2x00_request_firmware(vha);
        if (!blob) {
-               ql_log(ql_log_warn, vha, 0x0090,
-                   "Firmware image unavailable.\n");
                ql_log(ql_log_warn, vha, 0x0091,
                    "Firmware images can be retrieved from: "
                    QLA_FW_URL ".\n");
index 54380b434b304eddde918a94ee833e18be6a35f6..bebf12a86863cdca85a6ca3760eb6f15033a30ce 100644 (file)
@@ -2460,11 +2460,8 @@ try_blob_fw:
 
        /* Load firmware blob. */
        blob = ha->hablob = qla2x00_request_firmware(vha);
-       if (!blob) {
-               ql_log(ql_log_fatal, vha, 0x00a3,
-                   "Firmware image not present.\n");
+       if (!blob)
                goto fw_load_failed;
-       }
 
        /* Validating firmware blob */
        if (qla82xx_validate_firmware_blob(vha,
index e46e2c53871ac9dbfde6cf2e3d0e689ff859dc6b..e12f0657bd7454b2e2146491022c1470bdcfda48 100644 (file)
@@ -5622,8 +5622,6 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
                goto out;
 
        if (request_firmware(&blob->fw, blob->name, &ha->pdev->dev)) {
-               ql_log(ql_log_warn, vha, 0x0063,
-                   "Failed to load firmware image (%s).\n", blob->name);
                blob->fw = NULL;
                blob = NULL;
                goto out;
index 69bfc0a1aea30f99319ad50c6ecaec0649cf8862..9c0936094f181ace0fcb86c541cb56fd889cdbff 100644 (file)
@@ -475,11 +475,8 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti)
        int i, timeout;
 
        err = request_firmware(&fw, fwname, &qpti->op->dev);
-       if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
+       if (err)
                return err;
-       }
        if (fw->size % 2) {
                printk(KERN_ERR "Bogus length %zu in image \"%s\"\n",
                       fw->size, fwname);
index 3551aed589c010d5961e9e2f7672d6097a758232..9c1a89d3af2b7dda3ec205da990a414c79c322da 100644 (file)
@@ -762,9 +762,6 @@ static int fw_load(struct IR_tx *tx)
        /* Request codeset data file */
        ret = request_firmware(&fw_entry, "haup-ir-blaster.bin", tx->ir->l.dev);
        if (ret != 0) {
-               dev_err(tx->ir->l.dev,
-                       "firmware haup-ir-blaster.bin not available (%d)\n",
-                       ret);
                ret = ret < 0 ? ret : -EFAULT;
                goto out;
        }
index 08302dfb0d90dd884d8889f245a5d804b0bd0dd3..c2413c8fbca4b41c8f3dea976c75b450a46b13b7 100644 (file)
@@ -244,10 +244,8 @@ bool init_firmware(struct net_device *dev)
                 */
                if (rst_opt == OPT_SYSTEM_RESET) {
                        rc = request_firmware(&fw_entry, fw_name[init_step], &priv->udev->dev);
-                       if (rc < 0) {
-                               RT_TRACE(COMP_ERR, "request firmware fail!\n");
+                       if (rc)
                                goto download_firmware_fail;
-                       }
 
                        if (fw_entry->size > sizeof(pfirmware->firmware_buf)) {
                                RT_TRACE(COMP_ERR, "img file size exceed the container buffer fail!\n");
index 0dd458d1402c130b3f26bf89ba05835fa30d00f7..965f088c05a30f202cc7d6175dd9e60a44e12581 100644 (file)
@@ -67,8 +67,6 @@ int rtl871x_load_fw(struct _adapter *padapter)
        dev_info(dev, "r8712u: Loading firmware from \"%s\"\n", firmware_file);
        rc = request_firmware_nowait(THIS_MODULE, 1, firmware_file, dev,
                                     GFP_KERNEL, padapter, rtl871x_load_fw_cb);
-       if (rc)
-               dev_err(dev, "r8712u: Firmware request error %d\n", rc);
        return rc;
 }
 MODULE_FIRMWARE("rtlwifi/rtl8712u.bin");
index ac126d4f31172983fcdec97de13de8ff5e6ce161..5dcbe1dbba7693b1b22ede9769f2dde28fc683bf 100644 (file)
@@ -404,11 +404,8 @@ static int slic_card_download_gbrcv(struct adapter *adapter)
        }
 
        ret = request_firmware(&fw, file, &adapter->pcidev->dev);
-       if (ret) {
-               dev_err(&adapter->pcidev->dev,
-                       "Failed to load firmware %s\n", file);
+       if (ret)
                return ret;
-       }
 
        rcvucodelen = *(u32 *)(fw->data + index);
        index += 4;
@@ -482,11 +479,8 @@ static int slic_card_download(struct adapter *adapter)
                return -ENOENT;
        }
        ret = request_firmware(&fw, file, &adapter->pcidev->dev);
-       if (ret) {
-               dev_err(&adapter->pcidev->dev,
-                       "Failed to load firmware %s\n", file);
+       if (ret)
                return ret;
-       }
        numsects = *(u32 *)(fw->data + index);
        index += 4;
        for (i = 0; i < numsects; i++) {
index 1b48f9c86f63bd5c5e7c880bb9d67a50a15d7747..8558ba52c416c0648a029249469134bc557ce230 100644 (file)
@@ -49,11 +49,8 @@ int vnt_download_firmware(struct vnt_private *priv)
        dev_dbg(dev, "---->Download firmware\n");
 
        rc = request_firmware(&fw, FIRMWARE_NAME, dev);
-       if (rc) {
-               dev_err(dev, "firmware file %s request failed (%d)\n",
-                       FIRMWARE_NAME, rc);
-                       goto out;
-       }
+       if (rc)
+               goto out;
 
        buffer = kmalloc(FIRMWARE_CHUNK_SIZE, GFP_KERNEL);
        if (!buffer)
index 5e4fa920686151f94042af7b9e193d3d0486481f..c40a5c49b20d468674712c51f6567c9789cb3811 100644 (file)
@@ -3495,10 +3495,8 @@ static int cyz_load_fw(struct pci_dev *pdev, void __iomem *base_addr,
        int retval;
 
        retval = request_firmware(&fw, "cyzfirm.bin", &pdev->dev);
-       if (retval) {
-               dev_err(&pdev->dev, "can't get firmware\n");
+       if (retval)
                goto err;
-       }
 
        /* Check whether the firmware is already loaded and running. If
           positive, skip this board */
index 60d37b225589c25a509591f3076af353a19c752f..d5bf83758dc756433a37c6a8fe408e52a2ee121a 100644 (file)
@@ -866,13 +866,8 @@ static int moxa_init_board(struct moxa_board_conf *brd, struct device *dev)
        }
 
        ret = request_firmware(&fw, file, dev);
-       if (ret) {
-               printk(KERN_ERR "MOXA: request_firmware failed. Make sure "
-                               "you've placed '%s' file into your firmware "
-                               "loader directory (e.g. /lib/firmware)\n",
-                               file);
+       if (ret)
                goto err_free;
-       }
 
        ret = moxa_load_fw(brd, fw);
 
index c60a8d5e40201c535ac70a7ccfae67b813a9b790..cf3507bcc0edb0cf044a2a6c1e93a0f83572dfa7 100644 (file)
@@ -374,7 +374,6 @@ static void load_code(struct icom_port *icom_port)
 
        /* Load Call Setup into Adapter */
        if (request_firmware(&fw, "icom_call_setup.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_call_setup.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
@@ -394,7 +393,6 @@ static void load_code(struct icom_port *icom_port)
 
        /* Load Resident DCE portion of Adapter */
        if (request_firmware(&fw, "icom_res_dce.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_res_dce.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
@@ -439,7 +437,6 @@ static void load_code(struct icom_port *icom_port)
        }
 
        if (request_firmware(&fw, "icom_asc.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_asc.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
index 481eb2989a1e1cbf3a4bbc3274a74c4bb359e3d9..36c0ef138aaebda5593c8738af9b2194b827285d 100644 (file)
@@ -1167,10 +1167,8 @@ static void uart_firmware_cont(const struct firmware *fw, void *context)
        struct device *dev = context;
        int ret;
 
-       if (!fw) {
-               dev_err(dev, "firmware not found\n");
+       if (!fw)
                return;
-       }
 
        firmware = (struct qe_firmware *) fw->data;
 
index 0a866e90b49c80ee04061ae1af3ac5020dd3a237..79060b28fe8a4cd972a368bffbfd5b449157148a 100644 (file)
@@ -1088,8 +1088,6 @@ static int cxacru_find_firmware(struct cxacru_data *instance,
                return -ENOENT;
        }
 
-       usb_info(usbatm, "found firmware %s\n", buf);
-
        return 0;
 }
 
index 4333dc576a12321f4cdd88808ffb7a98dc5efc41..add5c1ffa50eac22016aac85bf0288bf37669438 100644 (file)
@@ -649,10 +649,8 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry,
        int ret, size;
 
        uea_enters(usb);
-       if (!fw_entry) {
-               uea_err(usb, "firmware is not available\n");
+       if (!fw_entry)
                goto err;
-       }
 
        pfw = fw_entry->data;
        size = fw_entry->size;
@@ -747,10 +745,6 @@ static int uea_load_firmware(struct usb_device *usb, unsigned int ver)
        ret = request_firmware_nowait(THIS_MODULE, 1, fw_name, &usb->dev,
                                        GFP_KERNEL, usb,
                                        uea_upload_pre_firmware);
-       if (ret)
-               uea_err(usb, "firmware %s is not available\n", fw_name);
-       else
-               uea_info(usb, "loading firmware %s\n", fw_name);
 
        uea_leaves(usb);
        return ret;
@@ -912,12 +906,8 @@ static int request_dsp(struct uea_softc *sc)
        }
 
        ret = request_firmware(&sc->dsp_firm, dsp_name, &sc->usb_dev->dev);
-       if (ret < 0) {
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                       dsp_name, ret);
+       if (ret)
                return ret;
-       }
 
        if (UEA_CHIP_VERSION(sc) == EAGLE_IV)
                ret = check_dsp_e4(sc->dsp_firm->data, sc->dsp_firm->size);
@@ -1630,12 +1620,8 @@ static int request_cmvs_old(struct uea_softc *sc,
 
        cmvs_file_name(sc, cmv_name, 1);
        ret = request_firmware(fw, cmv_name, &sc->usb_dev->dev);
-       if (ret < 0) {
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                      cmv_name, ret);
+       if (ret)
                return ret;
-       }
 
        data = (u8 *) (*fw)->data;
        size = (*fw)->size;
@@ -1672,9 +1658,6 @@ static int request_cmvs(struct uea_softc *sc,
                                "try to get older cmvs\n", cmv_name);
                        return request_cmvs_old(sc, cmvs, fw);
                }
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                      cmv_name, ret);
                return ret;
        }
 
@@ -1957,11 +1940,8 @@ static int load_XILINX_firmware(struct uea_softc *sc)
        uea_enters(INS_TO_USBDEV(sc));
 
        ret = request_firmware(&fw_entry, fw_name, &sc->usb_dev->dev);
-       if (ret) {
-               uea_err(INS_TO_USBDEV(sc), "firmware %s is not available\n",
-                      fw_name);
+       if (ret)
                goto err0;
-       }
 
        pfw = fw_entry->data;
        size = fw_entry->size;
index 8950fa5e973d6f100cb49e1fc2b7000564e27a4c..8dd7dbfb40293dd54a988bc0218da38b76cee460 100644 (file)
@@ -88,21 +88,17 @@ static int emi26_load_firmware (struct usb_device *dev)
 
        err = request_ihex_firmware(&loader_fw, "emi26/loader.fw", &dev->dev);
        if (err)
-               goto nofw;
+               goto wraperr;
 
        err = request_ihex_firmware(&bitstream_fw, "emi26/bitstream.fw",
                                    &dev->dev);
        if (err)
-               goto nofw;
+               goto wraperr;
 
        err = request_ihex_firmware(&firmware_fw, "emi26/firmware.fw",
                                    &dev->dev);
-       if (err) {
-       nofw:
-               dev_err(&dev->dev, "%s - request_firmware() failed\n",
-                       __func__);
+       if (err)
                goto wraperr;
-       }
 
        /* Assert reset (stop the CPU in the EMI) */
        err = emi26_set_reset(dev,1);
index 947811bc8126a086e84c7856eca80b70fa4e3121..f6a6091f343d91ecba73cb1c45b261cf8f3c9e9f 100644 (file)
@@ -79,12 +79,8 @@ static int ezusb_ihex_firmware_download(struct usb_device *dev,
        const struct ihex_binrec *record;
 
        if (request_ihex_firmware(&firmware, firmware_path,
-                                 &dev->dev)) {
-               dev_err(&dev->dev,
-                       "%s - request \"%s\" failed\n",
-                       __func__, firmware_path);
+                                 &dev->dev))
                goto out;
-       }
 
        ret = ezusb_set_reset(dev, fx.cpucs_reg, 0);
        if (ret < 0)
index 1c61830e96f956e6771a416dae0fb3b612317d64..9d59718528c636492229734fa41ff038774fbfea 100644 (file)
@@ -48,7 +48,6 @@ static int isight_firmware_load(struct usb_interface *intf,
                return -ENOMEM;
 
        if (request_firmware(&firmware, "isight.fw", &dev->dev) != 0) {
-               printk(KERN_ERR "Unable to load isight firmware\n");
                ret = -ENODEV;
                goto out;
        }
index 11c05ce2f35f8cd8ffe1ea46b0f6b0fed83e5064..b81b9fa526e07324fdf4fd3fb0c68905db5c1edd 100644 (file)
@@ -299,11 +299,8 @@ static void update_edgeport_E2PROM(struct edgeport_serial *edge_serial)
 
        response = request_ihex_firmware(&fw, fw_name,
                                         &edge_serial->serial->dev->dev);
-       if (response) {
-               dev_err(dev, "Failed to load image \"%s\" err %d\n",
-                      fw_name, response);
+       if (response)
                return;
-       }
 
        rec = (const struct ihex_binrec *)fw->data;
        BootMajorVersion = rec->data[0];
index fce82fd79f77bf59db864c2d1f09e166aa5d018a..9b1906fd5e845e31a5550c0c4f277fe34f1f2c1c 100644 (file)
@@ -1014,8 +1014,6 @@ static int download_fw(struct edgeport_serial *serial)
 
        status = request_firmware(&fw, fw_name, dev);
        if (status) {
-               dev_err(dev, "Failed to load image \"%s\" err %d\n",
-                               fw_name, status);
                return status;
        }
 
index 07b4bf01061d86a6aafcdbb9d7ee7b6d331b9a05..6059702f7e8c59b96c36d592dbb3a497cb972265 100644 (file)
@@ -1757,10 +1757,8 @@ static int ti_download_firmware(struct ti_device *tdev)
        }
 
 check_firmware:
-       if (status) {
-               dev_err(&dev->dev, "%s - firmware not found\n", __func__);
+       if (status)
                return -ENOENT;
-       }
        if (fw_p->size > TI_FIRMWARE_BUF_SIZE) {
                dev_err(&dev->dev, "%s - firmware too large %zu\n", __func__, fw_p->size);
                release_firmware(fw_p);
index 9f9a7bef1ff6d46d80fe8cb6dcfeea5a3e26729d..4b67783b3a56b20d39eccaaf24d654eb67d5ea6f 100644 (file)
@@ -743,10 +743,8 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev,
                return -EINVAL;
 
        err = request_firmware(&fw_entry, "broadsheet.wbf", dev);
-       if (err < 0) {
-               dev_err(dev, "Failed to get broadsheet waveform\n");
+       if (err)
                goto err_failed;
-       }
 
        /* try to enforce reasonable min max on waveform */
        if ((fw_entry->size < 8*1024) || (fw_entry->size > 64*1024)) {
index abb6bbf226d5232caa2b21495a0d65a5b204cbcf..0de622f104ae3ff476a4d4085d7922ebfa5a5904 100644 (file)
@@ -679,10 +679,8 @@ static int metronomefb_probe(struct platform_device *dev)
                a) request the waveform file from userspace
                b) process waveform and decode into metromem */
        retval = request_firmware(&fw_entry, "metronome.wbf", &dev->dev);
-       if (retval < 0) {
-               dev_err(&dev->dev, "Failed to get waveform\n");
+       if (retval)
                goto err_csum_table;
-       }
 
        retval = load_waveform((u8 *) fw_entry->data, fw_entry->size, 3, 31,
                                par);
index 3014b86362bdcaff723bc45b3567fb7d5fb02e83..671cdfa7f310ff0d8de1eff04c67cada94be37ad 100644 (file)
@@ -71,10 +71,8 @@ int snd_vx_setup_firmware(struct vx_core *chip)
                if (! fw_files[chip->type][i])
                        continue;
                sprintf(path, "vx/%s", fw_files[chip->type][i]);
-               if (request_firmware(&fw, path, chip->dev)) {
-                       snd_printk(KERN_ERR "vx: can't load firmware %s\n", path);
+               if (request_firmware(&fw, path, chip->dev))
                        return -ENOENT;
-               }
                err = chip->ops->load_dsp(chip, i, fw);
                if (err < 0) {
                        release_firmware(fw);
index 4c072666115dbd1d2559974fb5701592e7b8ba2a..9eaed8c999345736255d67749bc534d59ec4ac1a 100644 (file)
@@ -389,15 +389,11 @@ static int upload_dsp_code(struct snd_card *card)
        outb(HPBLKSEL_0, chip->io + HP_BLKS);
 
        err = request_firmware(&init_fw, INITCODEFILE, card->dev);
-       if (err < 0) {
-               printk(KERN_ERR LOGNAME ": Error loading " INITCODEFILE);
+       if (err)
                goto cleanup1;
-       }
        err = request_firmware(&perm_fw, PERMCODEFILE, card->dev);
-       if (err < 0) {
-               printk(KERN_ERR LOGNAME ": Error loading " PERMCODEFILE);
+       if (err)
                goto cleanup;
-       }
 
        memcpy_toio(chip->mappedbase, perm_fw->data, perm_fw->size);
        if (snd_msnd_upload_host(chip, init_fw->data, init_fw->size) < 0) {
index fdcfa29e220551b473534938d8995c7abf7ebe84..1d175a9063972e90435b2a86a1d4ae77fa3589ec 100644 (file)
@@ -544,10 +544,8 @@ static int sscape_upload_bootblock(struct snd_card *card)
        int ret;
 
        ret = request_firmware(&init_fw, "scope.cod", card->dev);
-       if (ret < 0) {
-               snd_printk(KERN_ERR "sscape: Error loading scope.cod");
+       if (ret)
                return ret;
-       }
        ret = upload_dma_data(sscape, init_fw->data, init_fw->size);
 
        release_firmware(init_fw);
@@ -584,11 +582,8 @@ static int sscape_upload_microcode(struct snd_card *card, int version)
        snprintf(name, sizeof(name), "sndscape.co%d", version);
 
        err = request_firmware(&init_fw, name, card->dev);
-       if (err < 0) {
-               snd_printk(KERN_ERR "sscape: Error loading sndscape.co%d",
-                               version);
+       if (err)
                return err;
-       }
        err = upload_dma_data(sscape, init_fw->data, init_fw->size);
        if (err == 0)
                snd_printk(KERN_INFO "sscape: MIDI firmware loaded %zu KBs\n",
index 718d5e3b7806f01da8782ed9955c9d5dd22db57a..ec57ca192c3ff57ed1e7cd86f7840ad0cb00d2a7 100644 (file)
@@ -1956,10 +1956,8 @@ wavefront_download_firmware (snd_wavefront_t *dev, char *path)
        const struct firmware *firmware;
 
        err = request_firmware(&firmware, path, dev->card->dev);
-       if (err < 0) {
-               snd_printk(KERN_ERR "firmware (%s) download failed!!!\n", path);
+       if (err)
                return 1;
-       }
 
        len = 0;
        buf = firmware->data;
index 3603c24f34d2d9a632223480fd5ec0d06023dd8b..bb748e14533e5af824e9eebae1e95239701dfb12 100644 (file)
@@ -46,8 +46,6 @@ short hpi_dsp_code_open(u32 adapter, void *os_data, struct dsp_code *dsp_code,
        err = request_firmware(&firmware, fw_name, &dev->dev);
 
        if (err || !firmware) {
-               dev_err(&dev->dev, "%d, request_firmware failed for %s\n",
-                       err, fw_name);
                goto error1;
        }
        if (firmware->size < sizeof(header)) {
index 2706f271a83b0f19cf7a83b833b9f4e3a35e4242..3b052f414f27de5be3b9188ce0b51bc4d7b82530 100644 (file)
@@ -3253,11 +3253,8 @@ int snd_cs46xx_start_dsp(struct snd_cs46xx *chip)
 #ifdef CONFIG_SND_CS46XX_NEW_DSP
        for (i = 0; i < CS46XX_DSP_MODULES; i++) {
                err = load_firmware(chip, &chip->modules[i], module_names[i]);
-               if (err < 0) {
-                       dev_err(chip->card->dev, "firmware load error [%s]\n",
-                                  module_names[i]);
+               if (err < 0)
                        return err;
-               }
                err = cs46xx_dsp_load_module(chip, chip->modules[i]);
                if (err < 0) {
                        dev_err(chip->card->dev, "image download error [%s]\n",
index 937071760bc4ac7197c4931452e903689fed671f..876b16518c531df923c5da40dde0d62aea4f0f36 100644 (file)
@@ -60,11 +60,8 @@ static int get_firmware(const struct firmware **fw_entry,
                "firmware requested: %s\n", card_fw[fw_index].data);
        snprintf(name, sizeof(name), "ea/%s", card_fw[fw_index].data);
        err = request_firmware(fw_entry, name, pci_device(chip));
-       if (err < 0)
-               dev_err(chip->card->dev,
-                       "get_firmware(): Firmware not available (%d)\n", err);
 #ifdef CONFIG_PM_SLEEP
-       else
+       if (!err)
                chip->fw_cache[fw_index] = *fw_entry;
 #endif
        return err;
index 891453451543102994b7912584f00483b2c472f0..5d09bda1db9822ee30ace901a63853545168c633 100644 (file)
@@ -901,12 +901,8 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu)
                }
 
                err = request_firmware(&emu->firmware, filename, &emu->pci->dev);
-               if (err != 0) {
-                       dev_info(emu->card->dev,
-                                "emu1010: firmware: %s not found. Err = %d\n",
-                                filename, err);
+               if (err != 0)
                        return err;
-               }
                dev_info(emu->card->dev,
                         "emu1010: firmware file = %s, size = 0x%zx\n",
                           filename, emu->firmware->size);
index 487fcbf9473e80a236533539e653b5e3c9e715fc..d0a78167f2767c06aa455b7da611b015712112f3 100644 (file)
@@ -1798,10 +1798,8 @@ static void azx_firmware_cb(const struct firmware *fw, void *context)
        struct azx *chip = card->private_data;
        struct pci_dev *pci = chip->pci;
 
-       if (!fw) {
-               dev_err(card->dev, "Cannot load firmware, aborting\n");
+       if (!fw)
                goto error;
-       }
 
        chip->fw = fw;
        if (!chip->disabled) {
index 9e1ad119a3ce0430579d648ae34e6eedc3b7af10..aa3224fe0dafcda7d49c62210c2727fe0951ef11 100644 (file)
@@ -2332,7 +2332,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci,
        err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev);
        if (err < 0) {
                release_firmware(dsp_code);
-               snd_printk(KERN_ERR "firmware not available\n");
                snd_korg1212_free(korg1212);
                return err;
        }
index 5bfd3ac80db5a24505a54fb133def69c13da5166..8dd77059a565bb26ba2d5066ed3b705d624ca0af 100644 (file)
@@ -571,11 +571,8 @@ int snd_mixart_setup_firmware(struct mixart_mgr *mgr)
 
        for (i = 0; i < 3; i++) {
                sprintf(path, "mixart/%s", fw_files[i]);
-               if (request_firmware(&fw_entry, path, &mgr->pci->dev)) {
-                       dev_err(&mgr->pci->dev,
-                               "miXart: can't load firmware %s\n", path);
+               if (request_firmware(&fw_entry, path, &mgr->pci->dev))
                        return -ENOENT;
-               }
                /* fake hwdep dsp record */
                err = mixart_dsp_load(mgr, i, fw_entry);
                release_firmware(fw_entry);
index 80633055e17e35c56131a24e1b373cd6d63d3989..17b185d16f649f64459302b429f7dde27c05b7f1 100644 (file)
@@ -385,12 +385,8 @@ int pcxhr_setup_firmware(struct pcxhr_mgr *mgr)
                if (!fw_files[fw_set][i])
                        continue;
                sprintf(path, "pcxhr/%s", fw_files[fw_set][i]);
-               if (request_firmware(&fw_entry, path, &mgr->pci->dev)) {
-                       dev_err(&mgr->pci->dev,
-                               "pcxhr: can't load firmware %s\n",
-                                  path);
+               if (request_firmware(&fw_entry, path, &mgr->pci->dev))
                        return -ENOENT;
-               }
                /* fake hwdep dsp record */
                err = pcxhr_dsp_load(mgr, i, fw_entry);
                release_firmware(fw_entry);
index 067a91207d8e53bc521988b449cd7a65b4308f63..25eebf442daf0f5eac0dfeb7dec6e483babfc6ff 100644 (file)
@@ -1231,11 +1231,8 @@ static int try_to_load_firmware(struct cmdif *cif, struct snd_riptide *chip)
        if (!chip->fw_entry) {
                err = request_firmware(&chip->fw_entry, "riptide.hex",
                                       &chip->pci->dev);
-               if (err) {
-                       snd_printk(KERN_ERR
-                                  "Riptide: Firmware not available %d\n", err);
+               if (err)
                        return -EIO;
-               }
        }
        err = loadfirmware(cif, chip->fw_entry->data, chip->fw_entry->size);
        if (err) {
index 7c8941b8b2defd9b21b8159f1cef333659ce423d..f005690c1eabc59dd6c40f32b9d1145291735803 100644 (file)
@@ -5103,11 +5103,8 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp)
                return -EINVAL;
        }
 
-       if (request_firmware(&fw, fwfile, &hdsp->pci->dev)) {
-               dev_err(hdsp->card->dev,
-                       "cannot load firmware %s\n", fwfile);
+       if (request_firmware(&fw, fwfile, &hdsp->pci->dev))
                return -ENOENT;
-       }
        if (fw->size < HDSP_FIRMWARE_SIZE) {
                dev_err(hdsp->card->dev,
                        "too short firmware size %d (expected %d)\n",
index f2664396be6fd752c3fa62f398a6e2e1857eef91..91525f7eabefc5cf78c8103f428fbdff000f4809 100644 (file)
@@ -889,10 +889,8 @@ static int wm2000_i2c_probe(struct i2c_client *i2c,
        }
 
        ret = request_firmware(&fw, filename, &i2c->dev);
-       if (ret != 0) {
-               dev_err(&i2c->dev, "Failed to acquire ANC data: %d\n", ret);
+       if (ret != 0)
                goto err_supplies;
-       }
 
        /* Pre-cook the concatenation of the register address onto the image */
        wm2000->anc_download_size = fw->size + 2;
index 9520b4cd703853cf4f5672c37da344ee3b214cbc..858ad4dd36d1348051ecd75c6746809a5ef9762f 100644 (file)
@@ -219,8 +219,6 @@ static int usb6fire_fw_ezusb_upload(
        ret = request_firmware(&fw, fwname, &device->dev);
        if (ret < 0) {
                kfree(rec);
-               dev_err(&intf->dev,
-                       "error requesting ezusb firmware %s.\n", fwname);
                return ret;
        }
        ret = usb6fire_fw_ihex_init(fw, rec);
@@ -296,8 +294,6 @@ static int usb6fire_fw_fpga_upload(
 
        ret = request_firmware(&fw, fwname, &device->dev);
        if (ret < 0) {
-               dev_err(&intf->dev, "unable to get fpga firmware %s.\n",
-                               fwname);
                kfree(buffer);
                return -EIO;
        }